Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer dependencies in /dist #68

Closed
nlemoine opened this issue Apr 27, 2021 · 5 comments
Closed

Composer dependencies in /dist #68

nlemoine opened this issue Apr 27, 2021 · 5 comments

Comments

@nlemoine
Copy link
Contributor

Hi,

Any reason for composer dependencies to be included in the dist folder? It's loading unused/dev dependencies and those are messing with my composer dependencies.

Would you consider moving those to require-dev and not adding them to the releases?

@darrenjacoby
Copy link
Owner

darrenjacoby commented Apr 28, 2021

@nlemoine sure yes! I think we only need tightenco in the dist folder, will test and update.

@nlemoine
Copy link
Contributor Author

Thanks!

BTW the way, since it's WordPress and you're using composer, it's usually a good practice to prefix your dependencies because someone might use the same package in a different version. This may lead to conflicts/errors.

See Yoast SEO (they use humbug/php-scoper) or WP Rocket (they use coenjacobs/mozart)

@darrenjacoby
Copy link
Owner

Thanks, will look into getting one of these options implemented!

@darrenjacoby
Copy link
Owner

Merged #69, thanks @nlemoine!

@nlemoine
Copy link
Contributor Author

nlemoine commented May 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants