Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated enable dead letter topic #913

Merged
merged 15 commits into from
Sep 15, 2023

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Sep 14, 2023

Description

Opened this PR since I didn't have permission to push to charlieMk1's fork to update his PR here.

All I've done is merge in master and make the names not overlap for integration tests to pass.

Issue reference

Will close: #848

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@cicoyle cicoyle requested review from a team as code owners September 14, 2023 18:17
@cicoyle cicoyle mentioned this pull request Sep 14, 2023
3 tasks
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 68.78% and project coverage change: -0.32% ⚠️

Comparison is base (cf8040d) 76.94% compared to head (347f299) 76.63%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #913      +/-   ##
============================================
- Coverage     76.94%   76.63%   -0.32%     
- Complexity     1326     1397      +71     
============================================
  Files           126      132       +6     
  Lines          4091     4254     +163     
  Branches        484      495      +11     
============================================
+ Hits           3148     3260     +112     
- Misses          696      735      +39     
- Partials        247      259      +12     
Files Changed Coverage Δ
...java/io/dapr/springboot/DaprTopicSubscription.java 60.00% <38.46%> (-25.00%) ⬇️
...c/main/java/io/dapr/workflows/WorkflowContext.java 41.17% <41.17%> (ø)
...va/io/dapr/springboot/DaprSubscriptionBuilder.java 50.00% <50.00%> (+1.28%) ⬆️
.../src/main/java/io/dapr/springboot/DaprRuntime.java 69.69% <57.14%> (-11.79%) ⬇️
...ava/io/dapr/workflows/runtime/ActivityWrapper.java 64.70% <64.70%> (ø)
...a/io/dapr/workflows/client/DaprWorkflowClient.java 80.95% <68.42%> (-10.36%) ⬇️
...apr/workflows/runtime/WorkflowActivityContext.java 71.42% <71.42%> (ø)
...ava/io/dapr/workflows/DaprWorkflowContextImpl.java 87.50% <78.57%> (-12.50%) ⬇️
.../dapr/workflows/runtime/WorkflowRuntimeStatus.java 79.41% <79.41%> (ø)
.../dapr/workflows/client/WorkflowFailureDetails.java 85.71% <85.71%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit 0543011 into dapr:master Sep 15, 2023
14 of 17 checks passed
@mukundansundar mukundansundar added this to the v1.10 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants