Enable dead letter topic #848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieMk1
force-pushed
the
enable_dead_letter_topic
branch
from
fc87bf9 to
7649ae4
Compare
charlieMk1
force-pushed
the
enable_dead_letter_topic
branch
from
a8714d5 to
7649ae4
Compare
Signed-off-by: Charlie Mk <[email protected]>
Signed-off-by: Charlie Mk <[email protected]>
Signed-off-by: Charlie Mk <[email protected]>
artursouza
requested changes
Apr 24, 2023
sdk-springboot/src/test/java/io/dapr/springboot/DaprRuntimeTest.java
Outdated
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicSubscription.java
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicSubscription.java
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprRuntime.java
Outdated
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprRuntime.java
Outdated
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
charlieMk1
force-pushed
the
enable_dead_letter_topic
branch
from
ebd66a7 to
eb6a149
Compare
…ones. Signed-off-by: Charlie Mk <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza
force-pushed
the
enable_dead_letter_topic
branch
from
74070be to
b2d5f36
Compare
Signed-off-by: Artur Souza <[email protected]>
artursouza
force-pushed
the
enable_dead_letter_topic
branch
from
b2d5f36 to
60cdd9e
Compare
artursouza
requested changes
May 24, 2023
| */ | ||
| @Topic(name = "testingtopic", pubsubName = "${myAppProperty:messagebus}", | ||
| deadLetterTopic = "${deadLetterProperty:deadTopic}") | ||
| @PostMapping(path = "/testingtopic") |
There was a problem hiding this comment.
This is breaking integration tests, please, use a different topic name and post mapping.
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
============================================
- Coverage 77.31% 77.01% -0.30%
- Complexity 1268 1270 +2
============================================
Files 117 117
Lines 3927 3951 +24
Branches 468 470 +2
============================================
+ Hits 3036 3043 +7
- Misses 652 667 +15
- Partials 239 241 +2
|
3 tasks
|
I opened the above PR to get this PR to a mergeable state, since I don't have permission to push to Charlie's branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #777 Add support for DLQ (dead letter queue)
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: