Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google Analytics 4 ID for v1.7 #2962

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Use Google Analytics 4 ID for v1.7 #2962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
582768d
Use Google Analytics 4 ID for v1.7
chalin Nov 18, 2022
fcc16e8
README: fix external link
chalin Nov 18, 2022
24ed16b
Fix PR template link
chalin Nov 18, 2022
e828487
Warn don't fail link-check issues
chalin Nov 19, 2022
18d96e5
Warn don't fail link-check issues, take 2
chalin Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Thank you for helping make the Dapr documentation better!

**Please follow this checklist before submitting:**
- [ ] Commits are signed with Developer Certificate of Origin (DCO - [learn more](https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work))
- [ ] [Read the contribution guide](https://docs.dapr.io/contributing/contributing-docs/)
- [ ] [Read the contribution guide](https://docs.dapr.io/contributing/docs-contrib/contributing-docs/)
- [ ] Commands include options for Linux, MacOS, and Windows within codetabs
- [ ] New file and folder names are globally unique
- [ ] Page references use shortcodes instead of markdown or URL links
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/link_validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
validate:
runs-on: ubuntu-latest
env:
env:
PYTHON_VER: 3.7
steps:
- uses: actions/checkout@v2
Expand All @@ -35,6 +35,6 @@ jobs:
python3 -m pip install --upgrade pip
pip3 install setuptools wheel twine tox mechanical-markdown
- name: Check Markdown Files
continue-on-error: true
run: |
for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name || exit 1 ;done

for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name ;done
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are legacy docs, and hence probably no longer actively updated, I figured that it would be ok to allow link validation to fail softly and not break the build.

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The following branches are currently maintained:
| [v1.8](https://github.com/dapr/docs) (primary) | https://docs.dapr.io | Latest Dapr release documentation. Typo fixes, clarifications, and most documentation goes here. |
| [v1.9](https://github.com/dapr/docs/tree/v1.9) (pre-release) | https://v1-9.docs.dapr.io/ | Pre-release documentation. Doc updates that are only applicable to v1.9+ go here. |

For more information visit the [Dapr branch structure](https://docs.dapr.io/contributing/contributing-docs/#branch-guidance) document.
For more information visit the [Dapr branch structure](https://docs.dapr.io/contributing/docs-contrib/contributing-docs/#branch-guidance) document.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update necessary so that the "validate links" GH action passes.

By the way, when website pages are moved, you should consider adding redirect rules to that users don't get 404s.


## Contribution guidelines

Expand Down
2 changes: 1 addition & 1 deletion daprdocs/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ disableKinds = ["taxonomy", "term"]

# Google Analytics
[services.googleAnalytics]
id = "UA-149338238-3"
id = "G-60C6Q1ETC1"

# Mounts
[module]
Expand Down