Use Google Analytics 4 ID for v1.7 #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrice Chalin <[email protected]>
11 tasks
Signed-off-by: Patrice Chalin <[email protected]>
chalin
commented
Nov 18, 2022
| For more information visit the [Dapr branch structure](https://docs.dapr.io/contributing/contributing-docs/#branch-guidance) document. | ||
| For more information visit the [Dapr branch structure](https://docs.dapr.io/contributing/docs-contrib/contributing-docs/#branch-guidance) document. |
There was a problem hiding this comment.
Update necessary so that the "validate links" GH action passes.
By the way, when website pages are moved, you should consider adding redirect rules to that users don't get 404s.
Signed-off-by: Patrice Chalin <[email protected]>
|
Well, I fixed the first few broken external links, but I'm going to stop now. Hopefully this PR can still be merged, or someone else can track down and fix all of the broken external links. |
Signed-off-by: Patrice Chalin <[email protected]>
chalin
commented
Nov 19, 2022
| @@ -36,5 +36,4 @@ jobs: | |||
| pip3 install setuptools wheel twine tox mechanical-markdown | |||
| - name: Check Markdown Files | |||
| run: | | |||
| for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name || exit 1 ;done | |||
|
|
|||
| for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name ;done | |||
There was a problem hiding this comment.
Since these are legacy docs, and hence probably no longer actively updated, I figured that it would be ok to allow link validation to fail softly and not break the build.
Signed-off-by: Patrice Chalin <[email protected]>
|
Ok, the build is passing now. PTAL @greenie-msft et al. |
|
Stale PR, paging all reviewers |
greenie-msft
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @msfussell @greenie-msft