Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google Analytics 4 ID for v1.9 #2941

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 7, 2022

Issue reference

Description

This is the first PR in a series, as we migrate to the new Dapr GA4 site tag.

IMPORTANT:

While we update the GA ID through the various doc versions/branches incrementally, I'll have to connect the GA4 ID to the original docs UA ID. Since the GA4 ID is the ID for all Dapr things web, this means that all web events, including page_views etc. from the main website, will be sent to the UA ID.

Please confirm that this is ok with you @berndverst et al.

/cc @berndverst @nate-double-u

Signed-off-by: Patrice Chalin <[email protected]>
@chalin chalin requested review from a team as code owners November 7, 2022 19:02
@chalin chalin mentioned this pull request Nov 7, 2022
11 tasks
@chalin
Copy link
Contributor Author

chalin commented Nov 7, 2022

@berndverst - if you'd prefer setting the ID through a build environment variable (as discussed in the Dapr maintainers list thread), rather than explicitly as is done in this PR, let me know. In that case, I'll submit another PR.

Regardless, I'll still need for you to confirm that you're ok with the docs UA ID being connected from the GA4 web data-stream (see the opening comment for details).

/cc @msfussell

@msfussell
Copy link
Member

@chalin - We are good with "'ll still need for you to confirm that you're ok with the docs UA ID being connected from the GA4 web data-stream (see the opening comment for details)." as the docs maintainers. I suggest merging this PR for now.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 0422117 into dapr:v1.9 Nov 8, 2022
@chalin chalin deleted the chalin-gp-ga4-v1.9-2022-11-07 branch November 8, 2022 17:56
msfussell added a commit that referenced this pull request Dec 21, 2022
* Fix: codeblock wasn't properly closed

Minor formatting fix.

Signed-off-by: Tiago Alves Macambira <[email protected]>

* update code examples

Signed-off-by: Hannah Hunter <[email protected]>

* Fix broken link in components-concept page

Commit 043a39d shuffled content around and removed a section called "Pluggable Components", breaking an existing link to this section. This PR fixes the link to point to the section now hosting the appropriate content.

Signed-off-by: Tiago Alves Macambira <[email protected]>

* Add Resiliency to the concepts page

Signed-off-by: Nick Greenfield <[email protected]>

* Update redis.md

Signed-off-by: wxbty <[email protected]>

* Remove ServiceInvocation.NoDefaultContentType feature flag

Fixes #2869

Signed-off-by: ItalyPaleAle <[email protected]>

* dotnet submodule

Signed-off-by: Hannah Hunter <[email protected]>

* Simplifying kubernetes YAML config (#2908)

* Simplifying Kubernetes YAML

Signed-off-by: Marcos Candeia <[email protected]>

* Update pluggable-components-registration.md

Signed-off-by: Marcos Candeia <[email protected]>

Signed-off-by: Marcos Candeia <[email protected]>

* Clarify GH actions doc (#2906)

* dotnet submodule

Signed-off-by: Hannah Hunter <[email protected]>

* attempt to clarify doc

Signed-off-by: Hannah Hunter <[email protected]>

* Revert "dotnet submodule"

This reverts commit 8fdeb61.

Signed-off-by: Hannah Hunter <[email protected]>

* dotnet submodule (#2904)

Signed-off-by: Hannah Hunter <[email protected]>

Signed-off-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Update latest Python SDK version

Signed-off-by: Bernd Verst <[email protected]>

* etag true for dynamodb (#2902)

Signed-off-by: Hannah Hunter <[email protected]>

Signed-off-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* [Run w/o docker] Add tabs and port number (#2905)

* add tabs and window example

Signed-off-by: Hannah Hunter <[email protected]>

* edits per Mark

Signed-off-by: Hannah Hunter <[email protected]>

Signed-off-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* 1/3 update per alecor191

Signed-off-by: Hannah Hunter <[email protected]>

* Update redis.md

Signed-off-by: wxbty <[email protected]>

* Add missing rocketmq pubsub to table

Signed-off-by: Bernd Verst <[email protected]>

* Update aws-secret-manager.md

Signed-off-by: vishalsignity <[email protected]>

* Update daprdocs/content/en/concepts/resiliency-concept.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: greenie-msft <[email protected]>

* Update daprdocs/content/en/concepts/resiliency-concept.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: greenie-msft <[email protected]>

* Update daprdocs/content/en/concepts/resiliency-concept.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: greenie-msft <[email protected]>

* Apply feedback to resiliency concept page

* Mark pubsub.hazelcast as deprecated

Fixes #2708

Signed-off-by: ItalyPaleAle <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-hazelcast.md

Co-authored-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Alessandro (Ale) Segala <[email protected]>

* update supported versions list (#2916)

* update supported versions list

Signed-off-by: Mukundan Sundararajan <[email protected]>

* updated supported versions

Signed-off-by: Mukundan Sundararajan <[email protected]>

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: greenie-msft <[email protected]>
Co-authored-by: greenie-msft <[email protected]>

* Update daprdocs/content/en/concepts/resiliency-concept.md

Signed-off-by: greenie-msft <[email protected]>

* Update azure-kubernetes-service-extension.md

Signed-off-by: greenie-msft <[email protected]>

* Update redis.md

Signed-off-by: wxbty <[email protected]>

* Update redis.md

Signed-off-by: wxbty <[email protected]>

* Update eventgrid.md command typos (#2932)

Signed-off-by: Ana Cozma <[email protected]>

Signed-off-by: Ana Cozma <[email protected]>

* Add sidecar health image and fix broken links

Signed-off-by: Nick Greenfield <[email protected]>

* update python to be declarative example

Signed-off-by: Hannah Hunter <[email protected]>

* Start of resiliency quickstart

Signed-off-by: Nick Greenfield <[email protected]>

* Update daprdocs/content/en/getting-started/quickstarts/resiliency-quickstart.md

Signed-off-by: greenie-msft <[email protected]>

* Update docs runtime version to 1.9.3

Signed-off-by: Nick Greenfield <[email protected]>

* Update azure-api-management.md

Removed one word

Signed-off-by: Richard de Zwart <[email protected]>

* Use Google Analytics 4 ID (#2941)

Signed-off-by: Patrice Chalin <[email protected]>

Signed-off-by: Patrice Chalin <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Fix Python SDK version

Signed-off-by: greenie-msft <[email protected]>

* update code snippets

Signed-off-by: Hannah Hunter <[email protected]>

* Azurite queue default port is 10001

fix: Update azurite port to 10001 instead of 10000

See [docs](https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio#queue-listening-port-configuration)

Signed-off-by: ThumNet <[email protected]>

* updates per resiliency example

Signed-off-by: Hannah Hunter <[email protected]>

* Add resiliency images for quickstarts

Signed-off-by: Nick Greenfield <[email protected]>

* Updates to resiliency svc invoke quickstart

* updates per Nick review

Signed-off-by: Hannah Hunter <[email protected]>

* Update daprdocs/content/en/developing-applications/integrations/Azure/azure-kubernetes-service-extension.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: greenie-msft <[email protected]>

* capitalize Dapr

Signed-off-by: Hannah Hunter <[email protected]>

* Update daprdocs/content/en/getting-started/quickstarts/resiliency/resiliency-state-quickstart.md

Signed-off-by: greenie-msft <[email protected]>

* Update daprdocs/content/en/getting-started/quickstarts/resiliency/resiliency-state-quickstart.md

Signed-off-by: greenie-msft <[email protected]>

* Update daprdocs/content/en/getting-started/quickstarts/resiliency/resiliency-state-quickstart.md

Signed-off-by: greenie-msft <[email protected]>

* Update daprdocs/content/en/getting-started/quickstarts/resiliency/resiliency-state-quickstart.md

Signed-off-by: greenie-msft <[email protected]>

* Update daprdocs/content/en/getting-started/quickstarts/resiliency/resiliency-state-quickstart.md

Signed-off-by: greenie-msft <[email protected]>

* Fix resiliency component quickstart

Signed-off-by: Nick Greenfield <[email protected]>

* Update runtime version to 1.9.4

Signed-off-by: Nick Greenfield <[email protected]>

* Update subscription examples (#2957)

* dotnet submodule

Signed-off-by: Hannah Hunter <[email protected]>

* update to v2alpha

Signed-off-by: Hannah Hunter <[email protected]>

* revert some changes

Signed-off-by: Hannah Hunter <[email protected]>

* update routes

Signed-off-by: Hannah Hunter <[email protected]>

Signed-off-by: Hannah Hunter <[email protected]>

* Kafka SASL SCRAM Authentication (#2939)

* Adds settings for SASL SCRAM SHA-256 and SHA-512

Signed-off-by: Andrew <[email protected]>

* Update setup-apache-kafka.md

Signed-off-by: Andrew <[email protected]>

Signed-off-by: Andrew <[email protected]>
Co-authored-by: Hannah Hunter <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>

* Update fluentd.md (#2967)

Elastic search installed by helm will version 8 series which does not let dapr connect with kibana(Because it enables authentication),
After using version 7 series works as expected

Signed-off-by: vikram-thiru <[email protected]>

Signed-off-by: vikram-thiru <[email protected]>

* Adding missing brace for json document example (#2968)

There is a missing brace in the example json

Signed-off-by: Chris Kingdon <[email protected]>

Signed-off-by: Chris Kingdon <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>

* Update Kubernetes job page (#2973)

Adds a paragraph mentioning `restartPolicy` needs to be set to `Never` for successful job completion.

Signed-off-by: Renato L. de F. Cunha <[email protected]>

Signed-off-by: Renato L. de F. Cunha <[email protected]>

* Remove backoffmaxretries from pubsub.mqtt metadata spec

Signed-off-by: shivam <[email protected]>

* Fix resiliency run command in quickstart (#2983)

Signed-off-by: Nick Greenfield <[email protected]>

Signed-off-by: Nick Greenfield <[email protected]>

* Update version to 1.9.5 (#2987)

* Updated per feedback

Signed-off-by: ItalyPaleAle <[email protected]>

* clarify app namespace

Signed-off-by: Hannah Hunter <[email protected]>

* Improve Hashicorp Vault documentation on CA certificates. (#2988)

* Improve Hashicorp Vault documentation on CA certificates.

Hashicorp Vault component documentation for CA related fields
(`caPem`, `caCert` and `caPath`) does not describe the precedence
among those flags and a big ambiguous on what those flags mean.

This PR tries to alliviate that.

Closes #2989

Signed-off-by: Tiago Alves Macambira <[email protected]>

* Apply suggestions from code review

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Tiago Alves Macambira <[email protected]>

Signed-off-by: Tiago Alves Macambira <[email protected]>
Co-authored-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Removing stored procedure references from cosmosDB docs (#3000)

Signed-off-by: Ryan Lettieri <[email protected]>

Signed-off-by: Ryan Lettieri <[email protected]>
Co-authored-by: Ryan Lettieri <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* fix broken ref in distributed_lock_api

Signed-off-by: Lenshood <[email protected]>

* Adding `helm repo update` (#3010)

Signed-off-by: salaboy <[email protected]>

Signed-off-by: salaboy <[email protected]>

* change link for sidecar security (#3011)

Signed-off-by: Hannah Hunter <[email protected]>

Signed-off-by: Hannah Hunter <[email protected]>

* update port to match go code (#3014)

Signed-off-by: Hannah Hunter <[email protected]>

Signed-off-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

Signed-off-by: Tiago Alves Macambira <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Nick Greenfield <[email protected]>
Signed-off-by: wxbty <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: Marcos Candeia <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: vishalsignity <[email protected]>
Signed-off-by: greenie-msft <[email protected]>
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Ana Cozma <[email protected]>
Signed-off-by: Richard de Zwart <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
Signed-off-by: ThumNet <[email protected]>
Signed-off-by: Andrew <[email protected]>
Signed-off-by: vikram-thiru <[email protected]>
Signed-off-by: Chris Kingdon <[email protected]>
Signed-off-by: Renato L. de F. Cunha <[email protected]>
Signed-off-by: shivam <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Lenshood <[email protected]>
Signed-off-by: salaboy <[email protected]>
Co-authored-by: Tiago Alves Macambira <[email protected]>
Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Nick Greenfield <[email protected]>
Co-authored-by: wxbty <[email protected]>
Co-authored-by: ItalyPaleAle <[email protected]>
Co-authored-by: Marcos Candeia <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Co-authored-by: Bernd Verst <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: vishalsignity <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Ana Cozma <[email protected]>
Co-authored-by: Richard de Zwart <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: ThumNet <[email protected]>
Co-authored-by: Jeffrey Tummers <[email protected]>
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: vikram-thiru <[email protected]>
Co-authored-by: Chris Kingdon <[email protected]>
Co-authored-by: Renato L. de F. Cunha <[email protected]>
Co-authored-by: shivam <[email protected]>
Co-authored-by: Ryan Lettieri <[email protected]>
Co-authored-by: Ryan Lettieri <[email protected]>
Co-authored-by: Lenshood <[email protected]>
Co-authored-by: salaboy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants