-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs upmerge 12/16 #3015
Merged
Merged
Docs upmerge 12/16 #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor formatting fix. Signed-off-by: Tiago Alves Macambira <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
Commit dapr@043a39d shuffled content around and removed a section called "Pluggable Components", breaking an existing link to this section. This PR fixes the link to point to the section now hosting the appropriate content. Signed-off-by: Tiago Alves Macambira <[email protected]>
Fix: codeblock wasn't properly closed
Fix broken link in components-concept page
Signed-off-by: Nick Greenfield <[email protected]>
Signed-off-by: wxbty <[email protected]>
Fixes dapr#2869 Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
* Simplifying Kubernetes YAML Signed-off-by: Marcos Candeia <[email protected]> * Update pluggable-components-registration.md Signed-off-by: Marcos Candeia <[email protected]> Signed-off-by: Marcos Candeia <[email protected]>
* dotnet submodule Signed-off-by: Hannah Hunter <[email protected]> * attempt to clarify doc Signed-off-by: Hannah Hunter <[email protected]> * Revert "dotnet submodule" This reverts commit 8fdeb61. Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
* add tabs and window example Signed-off-by: Hannah Hunter <[email protected]> * edits per Mark Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
Remove ServiceInvocation.NoDefaultContentType feature flag
Signed-off-by: Hannah Hunter <[email protected]>
Update azure-kubernetes-service-extension.md
Elastic search installed by helm will version 8 series which does not let dapr connect with kibana(Because it enables authentication), After using version 7 series works as expected Signed-off-by: vikram-thiru <[email protected]> Signed-off-by: vikram-thiru <[email protected]>
There is a missing brace in the example json Signed-off-by: Chris Kingdon <[email protected]> Signed-off-by: Chris Kingdon <[email protected]> Co-authored-by: Yaron Schneider <[email protected]>
Adds a paragraph mentioning `restartPolicy` needs to be set to `Never` for successful job completion. Signed-off-by: Renato L. de F. Cunha <[email protected]> Signed-off-by: Renato L. de F. Cunha <[email protected]>
Signed-off-by: shivam <[email protected]>
Signed-off-by: Nick Greenfield <[email protected]> Signed-off-by: Nick Greenfield <[email protected]>
Remove backoffmaxretries from pubsub.mqtt metadata spec
Signed-off-by: ItalyPaleAle <[email protected]>
Mark pubsub.hazelcast as deprecated
Signed-off-by: Hannah Hunter <[email protected]>
[Namespaces] clarify format is app.namespace
* Improve Hashicorp Vault documentation on CA certificates. Hashicorp Vault component documentation for CA related fields (`caPem`, `caCert` and `caPath`) does not describe the precedence among those flags and a big ambiguous on what those flags mean. This PR tries to alliviate that. Closes dapr#2989 Signed-off-by: Tiago Alves Macambira <[email protected]> * Apply suggestions from code review Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Tiago Alves Macambira <[email protected]> Signed-off-by: Tiago Alves Macambira <[email protected]> Co-authored-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]> Signed-off-by: Ryan Lettieri <[email protected]> Co-authored-by: Ryan Lettieri <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Lenshood <[email protected]>
Fix broken ref in distributed_lock_api
Signed-off-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
msfussell
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title