[1.12] pubsub/rabbitmq: return error if reconnect errors in Init #3199
Conversation
We should always return the error if we fail to connection during the Init of a Component. This is because failing to do so has downstream effects whereby a component is considered healthy when it is not. Re-attempting an Init or otherwise whould be handled by the runtime, rather than on a per-component basis. Signed-off-by: joshvanl <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #3199 +/- ##
================================================
+ Coverage 34.94% 35.44% +0.50%
================================================
Files 241 240 -1
Lines 29914 29441 -473
================================================
- Hits 10453 10436 -17
+ Misses 18579 18122 -457
- Partials 882 883 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Edit: somehow github told me to merge master into this... argh. I messed up the history - wasn't your fault @JoshVanL. Can you open / update this again? I wasn't able to merge it because Github said this was behind master for whatever reason, and updating the branch through the Github UI brought in all the wrong commits from master.
JoshVanL
force-pushed
the
release-1.12-pubsub-rabbitmq-init-error
branch
from
77d2371 to
8efc1a1
Compare
Backport of #3198