pubsub/rabbitmq: return error if reconnect errors in Init #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always return the error if we fail to connection during the Init of a Component. This is because failing to do so has downstream effects whereby a component is considered healthy when it is not. Re-attempting an Init or otherwise whould be handled by the runtime, rather than on a per-component basis. Signed-off-by: joshvanl <[email protected]>
JoshVanL
force-pushed
the
release-1.12-pubsub-rabbitmq-init-error
branch
from
0af7225 to
8efc1a1
Compare
JoshVanL
changed the title
Signed-off-by: Bernd Verst <[email protected]>
berndverst
approved these changes
Oct 27, 2023
|
oh.. now I see what happened here. Two PRs from the same branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always return the error if we fail to connection during the Init of a Component. This is because failing to do so has downstream effects whereby a component is considered healthy when it is not.
Re-attempting an Init or otherwise whould be handled by the runtime, rather than on a per-component basis.