Use revive instead of golint

[pigletfly]

Signed-off-by: pigletfly [email protected]

Description

The linter 'golint' is deprecated (since v1.41.0).ref: golangci/golangci-lint#1892

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

[daixiang0]

We need to keep the same consistent code style across all projects, so please open an issue for this and track it.

Honestly, I do not want to make this change, since no useful and necessary linter was introduced.

[pigletfly]

We need to keep the same consistent code style across all projects, so please open an issue for this and track it.

Honestly, I do not want to make this change, since no useful and necessary linter was introduced.

Task list is created, #1687. As said in the description, revive is a drop-in replacement, golint repo is archived already.

[shubham1172]

We need to keep the same consistent code style across all projects, so please open an issue for this and track it.

Honestly, I do not want to make this change, since no useful and necessary linter was introduced.

golint is now deprecated in favor of revive. We should update it here too.

[shubham1172]

Please address the requested changes.

[berndverst]

Please address the feedback from @shubham1172

[pigletfly]

a lot of new lint errors are coming.

[shubham1172]

@pigletfly Are the linter errors introduced due to golintci's version upgrade? If yes, we might need to fix them too.

[pigletfly]

@pigletfly Are the linter errors introduced due to golintci's version upgrade? If yes, we might need to fix them too.

I tested locally.It's the golangci-lint version upgrade.There are more linters in golangci-lint in newer version.One possible solution is we just choose linters that we want, such as

linters:
  fast: false
  enable:
    - revive

[pigletfly]

@daixiang0 any ideas ?

[shubham1172]

If there are some linters enabled out of box in the newer versions, we can choose to keep it (unless we are strongly opinionated about it).

[pigletfly]

these are new linters:

    - tparallel
    - paralleltest
    - wrapcheck
    - tagliatelle
    - ireturn
    - exhaustivestruct
    - errchkjson
    - contextcheck
    - gomoddirectives
    - godot
    - cyclop
    - varnamelen
    - gosec
    - errorlint
    - forcetypeassert
    - ifshort
    - maintidx
    - nilnil
    - predeclared
    - tenv
    - thelper
    - wastedassign
    - containedctx
    - gosimple

I disabled them locally,then there are only some stylecheck and staticcheck lint errors.

[shubham1172]

@berndverst do you think we should track a separate issue to re-enable the new linters and fix the linting issues in our code?

[ItalyPaleAle]

Note that as I just learnt, when updating to Go 1.18 a bunch of linters get disabled.

On dapr/dapr, with Go 1.18, golangci-lint now shows this:

WARN [linters context] bodyclose is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] nilerr is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] rowserrcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] sqlclosecheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] staticcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] stylecheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
WARN [linters context] unused is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 

This has caused MORE linter failures in the PR that switched to Go 1.18 because lint rules such as "nilerr" don't exist anymore, so //nolint:nilerr in itself throws an error.

So I wouldn't stress too much about what linters are enabled or disabled here, as when the PR to upgrade to Go 1.18 is merged, we'll have to revisit that anyways.

[daixiang0]

We should track linter changes and re-enable them when they are ready for Go 1.18.

[ItalyPaleAle]

We should track linter changes and re-enable them when they are ready for Go 1.18.

For the linters that are not available in 1.18, they are not explicitly disabled, so once golangci-lint is updated and adds them, they should be re-enabled automatically.

For the linters that were explicitly disabled in this PR, that's a different story.

[daixiang0]

Agree, but we need to update golangci-lint version, so still need to track.

[codecov]

Codecov Report

Merging #1685 (9deeddf) into master (bfd87eb) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
+ Coverage   36.37%   36.38%   +0.01%     
==========================================
  Files         166      166              
  Lines       15488    15488              
==========================================
+ Hits         5633     5635       +2     
+ Misses       9228     9227       -1     
+ Partials      627      626       -1     

Impacted Files	Coverage Δ
bindings/azure/cosmosdb/cosmosdb.go	18.00% <ø> (ø)
bindings/cron/cron.go	87.23% <ø> (ø)
bindings/http/http.go	87.87% <ø> (ø)
nameresolution/consul/configuration.go	96.59% <ø> (ø)
pubsub/azure/servicebus/message.go	85.84% <ø> (ø)
state/postgresql/postgresdbaccess.go	38.60% <0.00%> (ø)
state/redis/redis.go	35.00% <ø> (ø)
nameresolution/mdns/mdns.go	70.67% <0.00%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47db6cc...9deeddf. Read the comment docs.