Use revive instead of golint

Signed-off-by: pigletfly <[email protected]>
dapr · Apr 25, 2022 · 4f3047c · 4f3047c
1 parent a23fffb
commit 4f3047c
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/components-contrib.yml b/.github/workflows/components-contrib.yml
@@ -33,7 +33,7 @@ jobs:
       GOOS: ${{ matrix.target_os }}
       GOARCH: ${{ matrix.target_arch }}
       GOPROXY: https://proxy.golang.org
-      GOLANGCI_LINT_VER: v1.31
+      GOLANGCI_LINT_VER: v1.45.2
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]

diff --git a/.golangci.yml b/.golangci.yml
@@ -88,7 +88,7 @@ linters-settings:
     disable:
       - shadow
     disable-all: false
-  golint:
+  revive:
     # minimal confidence for issues, default is 0.8
     min-confidence: 0.8
   gofmt:
@@ -246,3 +246,4 @@ linters:
     - exhaustive
     - noctx
     - gci
+    - golint
diff --git a/bindings/http/http.go b/bindings/http/http.go
@@ -32,7 +32,7 @@ import (
 )
 
 // HTTPSource is a binding for an http url endpoint invocation
-// nolint:golint
+//revive:disable
 type HTTPSource struct {
 	metadata httpMetadata
 	client   *http.Client

diff --git a/nameresolution/consul/configuration.go b/nameresolution/consul/configuration.go
@@ -327,7 +327,7 @@ func mapAdvancedRegistration(config *AgentServiceRegistration) *consul.AgentServ
 	return mapped
 }
 
-//nolint:golint,stylecheck
+//revive:disable,stylecheck
 type HttpBasicAuth struct {
 	Username string
 	Password string
@@ -337,7 +337,7 @@ type Config struct {
 	Address    string
 	Scheme     string
 	Datacenter string
-	HttpAuth   *HttpBasicAuth //nolint:golint,stylecheck
+	HttpAuth   *HttpBasicAuth //revive:disable,stylecheck
 	WaitTime   time.Duration
 	Token      string
 	TokenFile  string

diff --git a/pubsub/azure/servicebus/message.go b/pubsub/azure/servicebus/message.go
@@ -114,7 +114,7 @@ func NewPubsubMessageFromASBMessage(asbMsg *azservicebus.Message, topic string)
 	// Always set delivery count.
 	addToMetadata(pubsubMsg, DeliveryCountMetadataKey, strconv.FormatInt(int64(asbMsg.DeliveryCount), 10))
 
-	//nolint:golint,nestif
+	//revive:disable,nestif
 	if asbMsg.SystemProperties != nil {
 		systemProps := asbMsg.SystemProperties
 		if systemProps.EnqueuedTime != nil {

diff --git a/state/redis/redis.go b/state/redis/redis.go
@@ -403,7 +403,7 @@ func (r *StateStore) Multi(request *state.TransactionalStateRequest) error {
 
 	pipe := r.client.TxPipeline()
 	for _, o := range request.Operations {
-		//nolint:golint,nestif
+		//revive:disable,nestif
 		if o.Operation == state.Upsert {
 			req := o.Request.(state.SetRequest)
 			ver, err := r.parseETag(&req)