Downgrade to lhci 0.8 #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse CI/lhci 0.10 introduces a change where it will respect the HTTP_PROXY url environment variable for API requests. Apparently this includes uploading reports to temporary storage. https://github.com/GoogleChrome/lighthouse-ci/releases/tag/v0.10.0 GoogleChrome/lighthouse-ci#727 As we setup Wiremock as a general HTTP proxy for Lighthouse requests to mock API requests, report uploads will also pass through Wiremock. This results in an error when uploading reports: FetchError: request to https://us-central1-lighthouse-infrastructure.cloudfunctions.net/saveHtmlReport failed, reason: self signed certificate in certificate chain To address this we either need to move away from browser proxying so we only use WireMock for specific external systems or setup the browser proxy to provide a trusted certificate chain. https://wiremock.org/docs/proxying/#browser-proxying-of-https
Running with lhci 0.9 upgrades to Lighthouse 9.3.0. This reveals new problems which causes our tests to fail. LCHI 0.8 was the original version we used before Dependabot started suggesting updates. Revert to this to ensure we have a working version. Then we will update LHCI at a later point in time when we have room to fix these issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We upgraded to Lighthouse 0.12 as suggested by Dependabot in #434. However this has introduced multiple problems:
First:
Lighthouse CI/lhci 0.10 introduces a change where it will respect the
HTTP_PROXY url environment variable for API requests. Apparently this
includes uploading reports to temporary storage.
https://github.com/GoogleChrome/lighthouse-ci/releases/tag/v0.10.0
GoogleChrome/lighthouse-ci#727
As we setup Wiremock as a general HTTP proxy for Lighthouse requests to
mock API requests, report uploads will also pass through Wiremock.
This results in an error when uploading reports:
FetchError: request to https://us-central1-lighthouse-infrastructure.cloudfunctions.net/saveHtmlReport failed, reason: self signed certificate in certificate chain
This is also visible in the output for the PR which introduced the upgrade #434 even though the action as a whole succeeded: https://github.com/danskernesdigitalebibliotek/dpl-cms/actions/runs/6588193517/job/17899940545
To address this we either need to move away from browser proxying so
we only use WireMock for specific external systems or setup the browser
proxy to provide a trusted certificate chain.
https://wiremock.org/docs/proxying/#browser-proxying-of-https
Second:
Running with lhci 0.9 upgrades to Lighthouse 9.3.0. This reveals new
problems which causes our tests to fail: https://github.com/danskernesdigitalebibliotek/dpl-cms/actions/runs/6695006011/job/18201354535
LCHI 0.8 was the original version we used before Dependabot started
suggesting updates. Revert to this to ensure we have a working version.
Then we will update LHCI at a later point in time when we have room to
fix these issues.