feat(cli): API requests will respect HTTP_PROXY env variable #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @nicksrandall can you sign the CLA please? |
|
@nicksrandall CLA? |
|
|
|
ahhhh, just had to re-run the actions 😅 |
kasperg
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Oct 30, 2023
Lighthouse CI/lhci 0.10 introduces a change where it will respect the HTTP_PROXY url environment variable for API requests. Apparently this includes uploading reports to temporary storage. https://github.com/GoogleChrome/lighthouse-ci/releases/tag/v0.10.0 GoogleChrome/lighthouse-ci#727 As we setup Wiremock as a general HTTP proxy for Lighthouse requests to mock API requests, report uploads will also pass through Wiremock. This results in an error when uploading reports: FetchError: request to https://us-central1-lighthouse-infrastructure.cloudfunctions.net/saveHtmlReport failed, reason: self signed certificate in certificate chain To address this we either need to move away from browser proxying so we only use WireMock for specific external systems or setup the browser proxy to provide a trusted certificate chain. https://wiremock.org/docs/proxying/#browser-proxying-of-https
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #574