Allow to ignore certain files from the Git repo change detection #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required changing the `buildNumber` data type from `long` to `String`. Fixes danielflower#75
This includes refactoring those methods that accept a ton of mojo configuration parameters. There is now a single class that wraps all of those. Fixes danielflower#77
|
@danielflower Any chance putting this in? |
|
This seems like a good change, but it's on top of #90 which I still haven't taken the time to fully understand and therefore commit to merging. I just commented on that one though in case people are interested enough to get this stuff done. #90 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes refactoring those methods that accept a ton of mojo configuration parameters. There is now a single class that wraps all of those.
Fixes #77
NOTE: this was built on top of #90 to avoid merge conflicts -> those changes from commit 1c661aa show up here as well. Merge #90 first!