-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the build number configurable in VersionNamer #75
Comments
@danielflower this seems like a useful new feature and a well thought-out idea. What do you think? Would a PR to that effect stand a chance getting accepted? |
marcelstoer
added a commit
to marcelstoer/multi-module-maven-release-plugin
that referenced
this issue
Sep 19, 2019
This required changing the `buildNumber` data type from `long` to `String`. Fixes danielflower#75
marcelstoer
added a commit
to marcelstoer/multi-module-maven-release-plugin
that referenced
this issue
Sep 19, 2019
This required changing the `buildNumber` data type from `long` to `String`. Fixes danielflower#75
marcelstoer
added a commit
to marcelstoer/multi-module-maven-release-plugin
that referenced
this issue
Oct 22, 2019
This required changing the `buildNumber` data type from `long` to `String`. Fixes danielflower#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi.
At the moment, the build number is just a long and there is, for what I can see, no way to configure it differently in order to get something like
<business-version>-<timestamp>-<commit-hash>
.There is already a delimiter property for separating the business version from "the rest", so what is missing is a way to specify such values.
The easiest way would be to make the buildNumber a
String
and it would then be up to the user to pass the value to use.In this way - as side effect - would also be possible to remove the build number if it's not wanted (keeping the
String
null
).A possible strategy would be:
Long
and, if it works, just useparsed-value + 1
The text was updated successfully, but these errors were encountered: