Slab effective ages (WIP) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edits for clarity. Please feel free to edit.
Editing for clarity. Added a sentence on using VS Code. Please feel free to edit.
More edits.
- put area/line/point features on a single page (pages were very short) - include a list of all current features
@tjhei Please check to see if this resolves your previous comments.
gwb-grid now has two new options: --filtered: This produces an additional <myfile>.filtered.vtu that removes background cells and cells tagged as "mantle layer" --by-tag: This additionally produces a sequence of files called <myfile>.N.vtu where N is an integer id of a "tag". Each file only contains the cells containing features with this tag.
Extensive editing for clarity. Hopefully, I have gotten this right. Read carefully for introduced typos. Please feel free to edit.
Co-authored-by: Timo Heister <[email protected]>
doc: feature list
Edits for clarity. Please feel free to edit.
…debug_mode Record debug mode
Update constant_angle_in_spherical_domain_issue.md
Update 02_your_first_input_file.md
Fixes inconsistencies in the depths between the json and the text. Additional edits to improve clarity (at least for me!) Please feel free to edit.
Update 01_input_design.md
…d_tests_for_variable_spreading Add tests for variable spreading
Update citing.md
add a new Plume feature
…limit-resolution Gwb grid limit resolution
…_fault_tolerance Loosen tolerance on Bezier curve Newton solver
…move_unnecessary_code Reduce unnecessary code and fix a typo
…elog_for_gwb_grid_limit_resolution Add changlog entry for gwb-grid limit resolution.
…plume.md Co-authored-by: Timo Heister <[email protected]>
…ction add description of the plume feature
max_values_in_array should be an integer not a double. Also update schema files.
…o make the mac compiler happy.
Fix ValueAtPoints data type
…ure_typos fix typo
…_seed_MPI_Rank Add rank to local random number seed.
…_declarations_and_docs update declarations files for plume feature.
|
Something seems to have happened and this picked up 87 commits from other people?? A similar thing happened to me at the hackathon and it was super annoying and I'm not sure if this is a remnant from that or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danieldouglas92 @MFraters
In this PR, I separate Daniel's implementation of the time shifts into a function to be tested with unit tests:
std::vector<double> calculate_effective_trench_and_plate_ages(std::vector<double> ridge_parameters, double distance_along_plane)I checked all tests currently passed and I'd like to chat with both you and Menno to figure out how we could have some unit tests for this function and the function
calculate_ridge_distance_and_spreadingOther than the tests, this makes the implementation of the mass-conserving temperature cleaner by calling this function