Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update declarations files for plume feature. #663

Merged

Conversation

MFraters
Copy link
Member

The plume feature was added in #620, but the declarations files where not updated. This pull request fixes that.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29e2468) 92.82% compared to head (492b0d3) 92.82%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         105      105           
  Lines        7176     7176           
=======================================
  Hits         6661     6661           
  Misses        515      515           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e2468...492b0d3. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.020 ± 0.004 (s=468) 1.013 ± 0.004 (s=420) -0.8% .. -0.6%
Slab interpolation curved simple none 1.028 ± 0.005 (s=462) 1.021 ± 0.005 (s=419) -0.8% .. -0.6%
Spherical slab interpolation simple none 1.172 ± 0.006 (s=385) 1.169 ± 0.007 (s=386) -0.4% .. -0.1%
Slab interpolation simple curved CMS 1.064 ± 0.006 (s=444) 1.067 ± 0.007 (s=403) +0.1% .. +0.4%
Spherical slab interpolation simple CMS 1.552 ± 0.011 (s=286) 1.551 ± 0.009 (s=297) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.174 ± 0.011 (s=371) 1.172 ± 0.005 (s=399) -0.3% .. +0.1%
Cartesian min max surface 2.299 ± 0.019 (s=202) 2.299 ± 0.018 (s=192) -0.3% .. +0.2%
Spherical min max surface 7.217 ± 0.023 (s=73) 7.218 ± 0.032 (s=54) -0.2% .. +0.3%

@MFraters MFraters merged commit d6df754 into GeodynamicWorldBuilder:main Feb 21, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant