Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag for skipping files inside vendor directory #139

Merged
merged 1 commit into from
Aug 8, 2023
Merged

add flag for skipping files inside vendor directory #139

merged 1 commit into from
Aug 8, 2023

Conversation

artuross
Copy link
Contributor

Added flag --skip-vendor as suggested in #129 for skipping files inside vendor directory.

pkg/gci/gci.go Outdated Show resolved Hide resolved
pkg/gci/gci.go Outdated Show resolved Hide resolved
@artuross artuross requested review from daixiang0 and xytan0056 and removed request for daixiang0 and xytan0056 March 5, 2023 19:04
pkg/io/search.go Outdated Show resolved Hide resolved
pkg/io/file.go Outdated Show resolved Hide resolved
@emilien-puget
Copy link

Hi, this feature is really a blocker for me to use this library, how could we move forward on this topic ?

@artuross
Copy link
Contributor Author

artuross commented Aug 7, 2023

@emilien-puget Thanks for reminding about this PR.

Copy link
Owner

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0 daixiang0 merged commit ef37fdd into daixiang0:master Aug 8, 2023
7 checks passed
@emilien-puget
Copy link

thank you all for your swift response, what are the next steps to integrate this new feature to golangci-lint, if any ?

@artuross artuross deleted the feature/flag-skip-vendor branch August 8, 2023 10:18
@artuross
Copy link
Contributor Author

artuross commented Aug 8, 2023

@emilien-puget need to wait for the next release of gci, then update the version in golangci-lint and add the flag in the settings and later pass the flag to io.GoFilesInPathsGenerator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants