Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional flag for ignoring vendor directory #129

Closed
artuross opened this issue Nov 24, 2022 · 1 comment
Closed

Add optional flag for ignoring vendor directory #129

artuross opened this issue Nov 24, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@artuross
Copy link
Contributor

Currently, gci formats files stored in vendor directory. With vendoring enabled in a repository, it requires gci to be executed for example with find which is not suitable:

find . -type f -name '*.go' -not -path "./vendor/*" -exec gci write --skip-generated --custom-order -s 'standard,default' {} \;

I suggest to add another feature flag, similar to --skip-generated to natively ignore vendor directories: --skip-vendor.

@artuross artuross changed the title Add option flag for ignoring vendor directory Add optional flag for ignoring vendor directory Nov 24, 2022
@daixiang0 daixiang0 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 25, 2022
@daixiang0
Copy link
Owner

Fixed by #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants