Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Axe runner Puppeteer adapter (AceGUI uses Electron instead) #227

Merged
merged 16 commits into from
May 5, 2019

Conversation

danielweck
Copy link
Member

@danielweck danielweck commented May 1, 2019

WIP!!
This PR code works just fine (it is really just a decoupling effort), with Ace GUI too.

@danielweck
Copy link
Member Author

Ace GUI PR: daisy/ace-gui#42

@danielweck danielweck requested a review from rdeltour May 2, 2019 22:29
@danielweck danielweck changed the title WIP - Puppeteer Axe runner (AceGUI will use Electron runner instead) WIP - Axe runner Puppeteer adapter (AceGUI uses Electron instead) May 3, 2019
Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment regarding the naming, which can be ignored. Otherwise all good! 👍

@danielweck danielweck merged commit 34c6e47 into master May 5, 2019
@danielweck danielweck deleted the feature/axe-runner branch May 5, 2019 20:03
danielweck added a commit to daisy/ace-gui that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants