WIP - Axe runner Electron adapter (Ace core uses Puppeteer instead) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: daisy/ace#227 |
|
Please note that packages dependencies in |
danielweck
changed the title
This was referenced May 3, 2019
rdeltour
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is working with the current version of Electron (v2). We can upgrade to v5 in a separate PR, at a later date (at which point I would recommend updating many other NPM packages too, across the Ace board, in order to address security holes, use latest performance improvements, etc.).
Meanwhile, we can keep this PR narrow-focused.
I compared the JSON reports (using a text-level diff tool) generated by Electron (Ace GUI) and Puppeteer (Ace core CLI), both Chromium but different versions ... everything looks good.