Publish 1.5.0 #49
Comments
Uses the 1.5.0 version of gc-stats, which unfortunately has not been properly released to npm: dainis/node-gcstats#49
Needed to upgrade the gc-stats package to 1.5.0, but that hasn't been released yet (dainis/node-gcstats#49) and also needed to bump service-runner to use this (wikimedia/service-runner#231). Also fixed some minor eslint issues and disabled `npm test` for the most part. Change-Id: I07752fd8ceeccdcced53db40be08f6b3ccea0661
|
👍 100% second this. Maybe merge PR #50 and publish v1.5.1? |
|
+1 |
|
@roikoren755, @baconandon & @thesocialdev is one of you perhaps interested in forking this repo and maintaining it? |
|
@otisg TBH I don't have available capacity to carry on with maintenance, but thanks for suggesting a fork. |
|
I've forked this repo and audited all dependencies. You can see it on Github, here, or on npm, here. |
|
Could you please also get rid of the bundledDependencies? Those should not be necessary anymore: Thanks! |
|
@gjasny any chance you can submit a PR for that to https://github.com/adnanrahic/node-gcstats ? |
|
Hey @gjasny. Could you open a PR in https://github.com/adnanrahic/node-gcstats with that edit and I'll review it ASAP? |
|
I'm travelling for the rest of the week. Wont be able to do this before
Monday morning.
Thanks,
Gregor
…On Thu, 22 Oct 2020, 10:48 Adnan Rahić, ***@***.***> wrote:
Hey @gjasny <https://github.com/gjasny>. Could you open a PR with that
edit and I'll review it ASAP.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI4SHQZDLCLVSNIG4W2BYLSL7WU5ANCNFSM4OFPGJLA>
.
|
|
Thanks @gjasny! There's no rush. I've opened an issue in the fork so we can keep track of it. Feel free to ping me or add me as a reviewer. 😄 👌 |
Needed to upgrade the gc-stats package to 1.5.0, but that hasn't been released yet (dainis/node-gcstats#49) and also needed to bump service-runner to use this (wikimedia/service-runner#231). Also fixed some minor eslint issues and disabled `npm test` for the most part. Bug: T268859 Change-Id: I07752fd8ceeccdcced53db40be08f6b3ccea0661 (cherry picked from commit 5995055)
|
ping? |
|
I'm maintaining a fork of this repo. Anything I can help you with? |
|
Can you push a new version to npm? And can you also publish pre-built binaries for alpine? |
|
As I said, I'm maintaining a fork, not this repo. To install the fork, you can run: I currently don't have any pre-built bins ready. You can open a PR and contribute that if you need it. I'd be happy to review the PR. 😄 |
It seems that v1.5.0 wasn't published to NPM, even though a commit was made to master with
[publish npm]in the name of the commit.Can you please publish this new version?
The text was updated successfully, but these errors were encountered: