Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled dependencies as they are not needed #1

Closed
adnanrahic opened this issue Oct 22, 2020 · 3 comments · Fixed by #6
Closed

Remove bundled dependencies as they are not needed #1

adnanrahic opened this issue Oct 22, 2020 · 3 comments · Fixed by #6

Comments

@adnanrahic
Copy link
Owner

adnanrahic commented Oct 22, 2020

Bundled dependencies should not be necessary anymore: https://github.com/mapbox/node-pre-gyp#configuring
https://github.com/adnanrahic/node-gcstats/blob/master/package.json#L35

Thanks @gjasny for letting me know!

@rohitkumarcs
Copy link

@adnanrahic

I see bundled dependencies still refers to "node-pre-gyp" after your latest merge to use @mapbox/node-pre-gyp.
Can we also replace it with @mapbox/node-pre-gyp in bundled dependencies also if not removing it all together? This will remove "node-pre-gyp" completely from module.

@Ghazgkull
Copy link

@adnanrahic @rohitkumarcs I went ahead and put together a PR to do this: #6

@adnanrahic adnanrahic linked a pull request Oct 4, 2021 that will close this issue
@adnanrahic
Copy link
Owner Author

This is a lovely PR. Thanks for taking a look. I just didn't have the bandwidth to check it out before now. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants