Issue-1 remove bundled node-pre-gyp #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Burns <[email protected]>
This was referenced Sep 29, 2021
|
@adnanrahic Can you please have a look at this PR? This completes the cleanup of any references to the deprecated |
|
Hey @adnanrahic, thank you for supporting this lib, and thank you @Ghazgkull for your PR. @adnanrahic Could you please review this? Looking forward to it! |
adnanrahic
approved these changes
Oct 4, 2021
|
Thanks @adnanrahic! Looking forward to the new release :) |
|
I've released a new version. It'll be available on NPM momentarily. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jared Burns [email protected]
Fixes Issue #1
This PR removes the bundled
node-pre-gyppackage, so that the@mapbox/node-pre-gyppackage gets used instead. It also updates all dependencies to latest and fixes up the package.json scripts so that they all work.