Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use node-loader again #103

Merged
merged 6 commits into from
Jul 15, 2023
Merged

feat: use node-loader again #103

merged 6 commits into from
Jul 15, 2023

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jul 10, 2023

Relates with #79 and #96

It partly reverts the idea in #21.

Closes #44

@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 0:49am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 160238f:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration

This was referenced Jul 12, 2023
@dai-shi
Copy link
Owner Author

dai-shi commented Jul 13, 2023

This doesn't fix #90. react-tweet uses CSS Modules, so externalizing it causes this error: [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".css" for ...

I have no idea how to fix this.

@dai-shi
Copy link
Owner Author

dai-shi commented Jul 13, 2023

If I added vite.config.ts for react-tweet,

import { defineConfig } from "waku/config";

export default defineConfig({
  ssr: {
    noExternal: ["react-tweet"],
  },
});

Now, it shows a different error: Warning: Invalid hook call. Hooks can only be called inside of the body of a function component.

Maybe because it has two different React instances?

@dai-shi
Copy link
Owner Author

dai-shi commented Jul 14, 2023

Not sure how many issues this will solve, but it should be good for now. (We don't know the future. There might be another/better way.)

@dai-shi dai-shi marked this pull request as ready for review July 14, 2023 12:55
@dai-shi dai-shi merged commit b682a9c into main Jul 15, 2023
@dai-shi dai-shi deleted the feat/use-node-loader branch July 15, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm doesn't work with waku/router
1 participant