-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use node-loader again #103
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 160238f:
|
This doesn't fix #90. react-tweet uses CSS Modules, so externalizing it causes this error: I have no idea how to fix this. |
If I added import { defineConfig } from "waku/config";
export default defineConfig({
ssr: {
noExternal: ["react-tweet"],
},
}); Now, it shows a different error: Maybe because it has two different React instances? |
Not sure how many issues this will solve, but it should be good for now. (We don't know the future. There might be another/better way.) |
Relates with #79 and #96
It partly reverts the idea in #21.
Closes #44