New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm doesn't work with waku/router #44

Closed

dai-shi opened this issue May 23, 2023 · 1 comment · Fixed by #103

Labels

bug help wanted

Owner

dai-shi commented May 23, 2023

waku/src/middleware/lib/rsc-handler-worker.ts

Lines 180 to 186 in 07ac23e

    
           ssr: { 
        
             // FIXME Without this, "use client" directive in waku/router/client 
        
             // is ignored, and some errors occur. 
        
             // Unless we fix this, RSC-capable packages aren't supported. 
        
             // This also seems to cause problems with pnpm. 
        
             noExternal: ["waku"], 
        
           },

dai-shi added bug help wanted labels

Contributor

himself65 commented May 25, 2023

Related: vitejs/vite#8991

dai-shi mentioned this issue

feat: use node-loader again #103

Merged

dai-shi closed this as completed in #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment