set all graphql context test suites to use code location test_location
#26174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jamiedemaria
force-pushed
the
jamie/update-gql-context-locations
branch
from
96c0a9e to
c4f164d
Compare
jamiedemaria
force-pushed
the
jamie/update-gql-context-locations
branch
7 times, most recently
from
781820c to
690af96
Compare
jamiedemaria
force-pushed
the
jamie/update-gql-context-locations
branch
from
690af96 to
a89676f
Compare
jamiedemaria
changed the title
test_location
gibsondan
approved these changes
Dec 3, 2024
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
…on` (#26174) ## Summary & Motivation updates the various graphql test suites to use code location name `test_location` rather than `test`. The `graphql_context` is set up with code location name `test_location`. This was causing issues in a test where the graphql_context expected the code location to be named `test_location` but the suite was initialized with code location name `test` ## How I Tested These Changes existing tests
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…on` (dagster-io#26174) ## Summary & Motivation updates the various graphql test suites to use code location name `test_location` rather than `test`. The `graphql_context` is set up with code location name `test_location`. This was causing issues in a test where the graphql_context expected the code location to be named `test_location` but the suite was initialized with code location name `test` ## How I Tested These Changes existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
updates the various graphql test suites to use code location name
test_locationrather thantest. Thegraphql_contextis set up with code location nametest_location. This was causing issues in a test where the graphql_context expected the code location to be namedtest_locationbut the suite was initialized with code location nametestHow I Tested These Changes
existing tests