Skip to content

Commit

Permalink
see what breaks
Browse files Browse the repository at this point in the history
  • Loading branch information
jamiedemaria committed Nov 27, 2024
1 parent 0306bc8 commit 96c0a9e
Showing 1 changed file with 20 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def _sqlite_asset_instance():

class EnvironmentManagers:
@staticmethod
def managed_grpc(target=None, location_name="test"):
def managed_grpc(target=None, location_name="test_location"):
@contextmanager
def _mgr_fn(instance, read_only):
"""Relies on webserver to load the code location in a subprocess and manage its lifecyle."""
Expand Down Expand Up @@ -302,7 +302,7 @@ def _mgr_fn(instance, read_only):
return MarkedManager(_mgr_fn, [Marks.managed_grpc_env])

@staticmethod
def deployed_grpc(target=None, location_name="test"):
def deployed_grpc(target=None, location_name="test_location"):
"""Launches a code server in a "dagster api grpc" subprocess."""

@contextmanager
Expand Down Expand Up @@ -332,7 +332,7 @@ def _mgr_fn(instance, read_only):
return MarkedManager(_mgr_fn, [Marks.deployed_grpc_env])

@staticmethod
def code_server_cli_grpc(target=None, location_name="test"):
def code_server_cli_grpc(target=None, location_name="test_location"):
"""Launches a code server in a "dagster code-server start" subprocess (which will
in turn open up a `dagster api grpc` subprocess that actually loads the code location).
"""
Expand Down Expand Up @@ -399,7 +399,7 @@ def _mgr_fn(instance, read_only):
python_file=file_relative_path(__file__, "repo.py"),
attribute="test_dict_repo",
working_directory=None,
location_name="test",
location_name="test_location",
),
version="",
read_only=read_only,
Expand Down Expand Up @@ -518,7 +518,9 @@ def sqlite_with_queued_run_coordinator_managed_grpc_env():
)

@staticmethod
def sqlite_with_default_run_launcher_managed_grpc_env(target=None, location_name="test"):
def sqlite_with_default_run_launcher_managed_grpc_env(
target=None, location_name="test_location"
):
return GraphQLContextVariant(
InstanceManagers.sqlite_instance_with_default_run_launcher(),
EnvironmentManagers.managed_grpc(target, location_name),
Expand All @@ -535,31 +537,39 @@ def sqlite_read_only_with_default_run_launcher_managed_grpc_env():
)

@staticmethod
def sqlite_with_default_run_launcher_deployed_grpc_env(target=None, location_name="test"):
def sqlite_with_default_run_launcher_deployed_grpc_env(
target=None, location_name="test_location"
):
return GraphQLContextVariant(
InstanceManagers.sqlite_instance_with_default_run_launcher(),
EnvironmentManagers.deployed_grpc(target, location_name),
test_id="sqlite_with_default_run_launcher_deployed_grpc_env",
)

@staticmethod
def sqlite_with_default_run_launcher_code_server_cli_env(target=None, location_name="test"):
def sqlite_with_default_run_launcher_code_server_cli_env(
target=None, location_name="test_location"
):
return GraphQLContextVariant(
InstanceManagers.sqlite_instance_with_default_run_launcher(),
EnvironmentManagers.code_server_cli_grpc(target, location_name),
test_id="sqlite_with_default_run_launcher_code_server_cli_env",
)

@staticmethod
def postgres_with_default_run_launcher_managed_grpc_env(target=None, location_name="test"):
def postgres_with_default_run_launcher_managed_grpc_env(
target=None, location_name="test_location"
):
return GraphQLContextVariant(
InstanceManagers.postgres_instance_with_default_run_launcher(),
EnvironmentManagers.managed_grpc(target, location_name),
test_id="postgres_with_default_run_launcher_managed_grpc_env",
)

@staticmethod
def postgres_with_default_run_launcher_deployed_grpc_env(target=None, location_name="test"):
def postgres_with_default_run_launcher_deployed_grpc_env(
target=None, location_name="test_location"
):
return GraphQLContextVariant(
InstanceManagers.postgres_instance_with_default_run_launcher(),
EnvironmentManagers.deployed_grpc(target, location_name),
Expand Down Expand Up @@ -655,7 +665,7 @@ def all_variants():
]

@staticmethod
def all_executing_variants(target=None, location_name="test"):
def all_executing_variants(target=None, location_name="test_location"):
return [
GraphQLContextVariant.sqlite_with_default_run_launcher_managed_grpc_env(
target, location_name
Expand Down

0 comments on commit 96c0a9e

Please sign in to comment.