[bugfix] Make ScheduleDefinition.with_job pass tags correctly #26042
+42
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smackesey
force-pushed
the
sean/schedule-with-updated-job-pass-tags
branch
from
b5d3172 to
e7c1e7f
Compare
jamiedemaria
approved these changes
Dec 2, 2024
| @@ -559,7 +559,7 @@ def with_updated_job(self, new_job: ExecutableDefinition) -> "ScheduleDefinition | |||
| required_resource_keys=self._raw_required_resource_keys, | |||
| run_config=None, # run_config, tags, should_execute encapsulated in execution_fn | |||
There was a problem hiding this comment.
is this comment incorrect then? maybe it's meant to be tags_fn?
| @@ -559,7 +559,7 @@ def with_updated_job(self, new_job: ExecutableDefinition) -> "ScheduleDefinition | |||
| required_resource_keys=self._raw_required_resource_keys, | |||
| run_config=None, # run_config, tags, should_execute encapsulated in execution_fn | |||
| run_config_fn=None, | |||
| tags=None, | |||
| tags=self.tags, | |||
There was a problem hiding this comment.
Not related to this PR, but while you're here, i noticed that the docstring at line 546 uses the wrong param name
smackesey
force-pushed
the
sean/schedule-with-updated-job-pass-tags
branch
from
e7c1e7f to
86bbb1f
Compare
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
Linear: https://linear.app/dagster-labs/issue/BUILD-435/fix-scheduledefinitionwith-updated-job ## Summary & Motivation Make `ScheduleDefinition.with_updated_job` correctly copy the `tags` on the `ScheduleDefinition`. ## How I Tested These Changes New unit test.
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…r-io#26042) Linear: https://linear.app/dagster-labs/issue/BUILD-435/fix-scheduledefinitionwith-updated-job ## Summary & Motivation Make `ScheduleDefinition.with_updated_job` correctly copy the `tags` on the `ScheduleDefinition`. ## How I Tested These Changes New unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/dagster-labs/issue/BUILD-435/fix-scheduledefinitionwith-updated-job
Summary & Motivation
Make
ScheduleDefinition.with_updated_jobcorrectly copy thetagson theScheduleDefinition.How I Tested These Changes
New unit test.