[bugfix] Make ScheduleDefinition.with_job pass tags correctly (#26042)

Linear:
https://linear.app/dagster-labs/issue/BUILD-435/fix-scheduledefinitionwith-updated-job

## Summary & Motivation

Make `ScheduleDefinition.with_updated_job` correctly copy the `tags` on
the `ScheduleDefinition`.

## How I Tested These Changes

New unit test.

python_modules/dagster/dagster/_core/definitions/schedule_definition.py

@@ -543,7 +543,7 @@ def with_updated_job(self, new_job: ExecutableDefinition) -> "ScheduleDefinition
         """Returns a copy of this schedule with the job replaced.
 
         Args:
-            job (ExecutableDefinition): The job that should execute when this
+            new_job (ExecutableDefinition): The job that should execute when this
                 schedule runs.
         """
         return ScheduleDefinition.dagster_internal_init(
@@ -557,9 +557,14 @@ def with_updated_job(self, new_job: ExecutableDefinition) -> "ScheduleDefinition
             default_status=self.default_status,
             environment_vars=self._environment_vars,
             required_resource_keys=self._raw_required_resource_keys,
-            run_config=None,  # run_config, tags, should_execute encapsulated in execution_fn
+            # run_config, run_config_fn, tags_fn, should_execute are not copied because the schedule constructor
+            # incorporates them into the execution_fn defined in the constructor. Since we are
+            # copying the execution_fn, we don't need to copy these, and it would actually be an
+            # error to do so (since you can't pass an execution_fn and any of these values
+            # simultaneously).
+            run_config=None,
             run_config_fn=None,
-            tags=None,
+            tags=self.tags,
             tags_fn=None,
             metadata=self.metadata,
             should_execute=None,

python_modules/dagster/dagster_tests/definitions_tests/test_schedule.py

@@ -2,9 +2,16 @@
 from datetime import datetime
 
 import pytest
-from dagster import DagsterInvalidDefinitionError, ScheduleDefinition, build_schedule_context, graph
-from dagster._core.definitions.decorators.op_decorator import op
+from dagster import (
+    DagsterInvalidDefinitionError,
+    ScheduleDefinition,
+    build_schedule_context,
+    graph,
+    job,
+    op,
+)
 from dagster._core.definitions.job_definition import JobDefinition
+from dagster._core.definitions.metadata.metadata_value import MetadataValue
 from dagster._core.definitions.run_config import RunConfig
 from dagster._core.definitions.run_request import RunRequest
 
@@ -165,3 +172,28 @@ def test_tag_transfer_to_run_request():
     assert (
         "foo" not in tags_and_exec_fn_schedule.evaluate_tick(context_with_time).run_requests[0].tags
     )
+
+
+def test_with_updated_job():
+    @op
+    def my_op():
+        pass
+
+    @job
+    def my_job_1():
+        my_op()
+
+    @job
+    def my_job_2():
+        my_op()
+
+    my_schedule_1 = ScheduleDefinition(
+        job=my_job_1, cron_schedule="@daily", tags={"foo": "bar"}, metadata={"baz": "qux"}
+    )
+
+    my_schedule_2 = my_schedule_1.with_updated_job(my_job_2)
+
+    assert my_schedule_2.job.name == "my_job_2"
+    assert my_schedule_2.cron_schedule == "@daily"
+    assert my_schedule_2.tags == {"foo": "bar"}
+    assert my_schedule_2.metadata == {"baz": MetadataValue.text("qux")}