Move AssetSelection from BaseModel to DagsterModel
#20638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sryza
force-pushed
the
asset-selection-strict-model
branch
from
65b1fa7 to
4399858
Compare
branch-name: strict-model
sryza
force-pushed
the
asset-selection-strict-model
branch
from
4399858 to
3e7b869
Compare
maximearmstrong
approved these changes
Mar 22, 2024
branch-name: asset-selection-strict-model
sryza
force-pushed
the
asset-selection-strict-model
branch
from
3e7b869 to
f549564
Compare
sryza
changed the title
AssetSelection from BaseModel to StrictModelAssetSelection from BaseModel to DagsterModel
sryza
added a commit
that referenced
this pull request
Mar 25, 2024
## Summary & Motivation Introduces a `StrictModel` class, which is a subclass of `pydantic.BaseModel` that's frozen and doesn't allow default constructor arguments that aren't class members. The idea is for this to eventually replace all our uses of `NamedTuple`, `BaseModel`, and `@dataclass`. This is a replacement for the unmerged #20461. Downstream PRs that demonstrate its usage: - #20641 - #20643 - #20638 ## How I Tested These Changes
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Introduces a `StrictModel` class, which is a subclass of `pydantic.BaseModel` that's frozen and doesn't allow default constructor arguments that aren't class members. The idea is for this to eventually replace all our uses of `NamedTuple`, `BaseModel`, and `@dataclass`. This is a replacement for the unmerged #20461. Downstream PRs that demonstrate its usage: - #20641 - #20643 - #20638 ## How I Tested These Changes
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Uses the
DagsterModelintroduced in #20637 forAssetSelection.How I Tested These Changes