Handle partitions natively in W&B IO Manager #15170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @yuhan will be best situated to review this PR, but she is out on vacation until mid next week! |
yuhan
reviewed
Jul 19, 2023
| }, | ||
| output_required=False, | ||
| ) | ||
| def read_objects_directly(context, partitions): |
There was a problem hiding this comment.
trying to wrap my head around here. where does the partitions come from?
There was a problem hiding this comment.
From the AssetIn
|
the test is mostly green except for the formatting/linting. could you run |
|
@yuhan Code is linted, I had to pull the latest master to get the new config :) |
yuhan
approved these changes
Aug 1, 2023
Update this repo with the latest master of dagster repo
|
The build failure should have been resolved on master. I tested this PR + latest master here: #15758 the build is green. |
PedramNavid
pushed a commit
that referenced
this pull request
Sep 12, 2023
## Summary & Motivation This PR aims to enrich the W&B integration by enhancing the functionality and user experience of the IO manager. We've focused on native handling of (multi-)partitioned assets, which streamlines the process and ensures our implementation is more robust. We also addressed and resolved several bugs, to provide a more seamless experience to users. In our commitment to clarity and ease of use, we've added comprehensive examples showcasing the use of partitions and multi-partitions, as well as how to specify a version or alias in the configuration metadata. We’ve also given much-needed attention to user-facing errors, rewording them for better understanding and visibility. Moreover, we introduced additional errors to alert users when there might be issues with their provided configuration, improving their ability to self-diagnose and rectify issues. ## How I Tested These Changes The examples added were run in multiple scenarios to ensure that they cover common use cases and successfully demonstrate the intended functionality. We also replicated common bugs that were reported, and confirmed that the fixes eliminated these issues. Lastly, we ensured backward compatibility and non-disruptive deployment with integration tests. We're excited to share these updates and we believe these improvements will significantly enhance the user's experience. Looking forward to your feedback, Dagster team! --------- Co-authored-by: yuhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR aims to enrich the W&B integration by enhancing the functionality and user experience of the IO manager. We've focused on native handling of (multi-)partitioned assets, which streamlines the process and ensures our implementation is more robust. We also addressed and resolved several bugs, to provide a more seamless experience to users.
In our commitment to clarity and ease of use, we've added comprehensive examples showcasing the use of partitions and multi-partitions, as well as how to specify a version or alias in the configuration metadata.
We’ve also given much-needed attention to user-facing errors, rewording them for better understanding and visibility. Moreover, we introduced additional errors to alert users when there might be issues with their provided configuration, improving their ability to self-diagnose and rectify issues.
How I Tested These Changes
The examples added were run in multiple scenarios to ensure that they cover common use cases and successfully demonstrate the intended functionality.
We also replicated common bugs that were reported, and confirmed that the fixes eliminated these issues.
Lastly, we ensured backward compatibility and non-disruptive deployment with integration tests.
We're excited to share these updates and we believe these improvements will significantly enhance the user's experience. Looking forward to your feedback, Dagster team!