Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleNotFoundError: No module named 'wandb.sdk.wandb_artifacts' when importing wandb_artifacts_io_manager #15497

Open
xinbeiG opened this issue Jul 24, 2023 · 2 comments
Labels
type: bug Something isn't working

Comments

@xinbeiG
Copy link

xinbeiG commented Jul 24, 2023

Dagster version

dagster, version 1.3.3

What's the issue?

I'm trying to import wandb_artifacts_io_manager like this:

from dagster_wandb import wandb_artifacts_io_manager

Traceback:

  File "/home/Packages/anaconda3/envs/myenv/lib/python3.8/site-packages/dagster_wandb/__init__.py", line 3, in <module>
    from .io_manager import WandbArtifactsIOManagerError, wandb_artifacts_io_manager
  File "/home/Packages/anaconda3/envs/myenv/lib/python3.8/site-packages/dagster_wandb/io_manager.py", line 23, in <module>
    from wandb.sdk.wandb_artifacts import Artifact
ModuleNotFoundError: No module named 'wandb.sdk.wandb_artifacts'

Other package version:

Name: dagster-wandb
Version: 0.19.3

I think the change from wandb/sdk/__init__.py caused this issue.
Changing from wandb.sdk.wandb_artifacts import Artifact to from wandb.sdk.artifacts.artifact import Artifact in dagster_wandb/io_manager.py should be able to fix this issue.

What did you expect to happen?

No response

How to reproduce?

No response

Deployment type

Local

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@xinbeiG xinbeiG added the type: bug Something isn't working label Jul 24, 2023
@yuhan
Copy link
Contributor

yuhan commented Jul 26, 2023

@chrishiste mind taking a look to confirm whether this was intentional or an oversight

@chrishiste
Copy link
Contributor

chrishiste commented Jul 28, 2023

@xinbeiG Thanks for opening this issue. You are right the change in the SDK broke this import. Fortunately, we already have a PR that includes a fix for this problem as well as other improvements: #15170

ScreenShot 2023-07-28 at 09 10 38@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants