chore: Add a global config to enable pprof #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
changed the title
jschwinger233
force-pushed
the
gray/pprof
branch
from
b3e0320 to
9d207b5
Compare
sumire88
previously approved these changes
Jun 11, 2024
|
我之前测试的时候发现引入 http 包会带来比较大的二进制大小膨胀，可以麻烦测试一下吗？ |
|
@mzz2017 我对比了下 PR build: https://github.com/daeuniverse/dae/actions/runs/9441996291?pr=532
会增加 0.3MB 大小 |
mzz2017
previously approved these changes
Jun 15, 2024
jschwinger233
force-pushed
the
gray/pprof
branch
from
9d207b5 to
f62e272
Compare
|
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
mzz2017
reviewed
Jun 15, 2024
jschwinger233
force-pushed
the
gray/pprof
branch
from
76caabb to
113390b
Compare
|
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
mzz2017
approved these changes
Jun 16, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR adds a new global config
pprof_portto specify (and enable/disable) pprof server. Users can also enable or disable pprof on the fly usingdae reload.Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result