Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add Golang diagnose support #523

Closed
jschwinger233 opened this issue May 23, 2024 · 2 comments
Closed

[Enhancement] Add Golang diagnose support #523

jschwinger233 opened this issue May 23, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jschwinger233
Copy link
Member

Improvement Suggestion

We noticed community feedback that dae may cause high memory usage. Let's add Golang diagnose support for dae.

It could be either adding --pprof command line argument to enable pprof, or integrating with https://github.com/google/gops into dae.

Potential Benefits

Only with these support we can tell if there is memory leak / goroutine leak.
@jschwinger233 jschwinger233 added enhancement New feature or request good first issue Good for newcomers labels May 23, 2024
@dae-prow
Copy link
Contributor

dae-prow bot commented May 23, 2024

Thanks for opening this issue!

@mzz2017
Copy link
Contributor

mzz2017 commented Jun 16, 2024

Closed by #532

@mzz2017 mzz2017 closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jschwinger233 @mzz2017