-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no support for {{!-- --}} style commenting #18
Comments
Hmm, I guess this commenting style could just be the default? Is there any reason not to use it everywhere? Otherwise things might get a bit confusing as ideally the package should support HTML comments as per #11 |
http://handlebarsjs.com/#Comments The difference is similar to difference between |
But that means that there's no harm in just using It would prevent errors when there's a Handlebars block / token in the commented out part so much less error prone to use. The whole comment gets stripped out from the rendered template so even those few extra characters can't be a problem. Or do you see some particular value keeping the single line |
|
@timohofmeijer Ditto on that last comment. It just looks broken, because it stops muting the color once it hits the first |
This is fixed now :) |
alt-command-slash (Mac) on text-selection should wrap the selection in a {{!-- --}} type comment. This allows commenting code blocks which contain other hbs expressions.
Highlighting of these type of comments would also be great!
The text was updated successfully, but these errors were encountered: