Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using command + / on an HTML comment results in it being surrounded by a Handlebars comment #11

Open
lazd opened this issue May 12, 2013 · 4 comments

Comments

@lazd
Copy link

lazd commented May 12, 2013

Steps:

  1. Create a template, template.hbs
  2. Open it in Sublime
  3. Add a comment with HTML in it:
<!-- <a href="http://moo.cow.com/">Link</a> -->
  1. Select the comment (from < to >) and press command + /

Result:

Selection is wrapped in Handlebars comment:

{{! <!-- <a href="http://moo.cow.com/">Link</a> --> }}

Expected:

Selection is uncommented:

<a href="http://moo.cow.com/">Link</a>
@daaain
Copy link
Owner

daaain commented May 14, 2013

This is a tricky one, I'm not sure what would be a good way to handle both Handlebars and HTML comments.

Since we're in Handlebars context I'd say Handlebars comments should take precedence and use the / + / shortcut, but a separate one for HTML comments should probably be available. Maybe + / + /?

@henrahmagix
Copy link

Unfortunately + + / is a global shortcut to opening the Help menu search box, so best not override that =)

@daaain
Copy link
Owner

daaain commented May 29, 2013

Ouch, haven't actually tried pressing the combination before suggesting! :)

+ + / seems to be available though? Wonder if it's free on Windows and Linux...

@timohofmeijer
Copy link

I too vote for prioritizing handlebars comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants