👷 Change build and run analysis conditions #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devbyaccident
force-pushed
the
feature/cbl/add-docker-condition
branch
from
947a934 to
67a5c34
Compare
devbyaccident
force-pushed
the
feature/cbl/add-docker-condition
branch
from
ddb9c33 to
8f16cf5
Compare
devbyaccident
commented
Oct 10, 2023
| branches: | ||
| - 'dev' | ||
| paths: | ||
| - 'Dockerfile' |
There was a problem hiding this comment.
This condition will only trigger if a commit is merged into the dev branch AND that commit has a change to the Dockerfile.
| jobs: | ||
| build_and_publish_image: | ||
| name: Build and Publish Image | ||
| runs-on: ubuntu-latest-m |
There was a problem hiding this comment.
Using the large runner to build since it will be more infrequent per the condition above.
Comment on lines
4
to
5
| pull_request: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
This is the analysis workflow now. It will trigger due to either of the below conditions:
- A new PR is opened
- A manual workflow is triggered through the GitHub Actions console
| @@ -166,19 +123,19 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
|
|
|||
| - name: Download Data | |||
| uses: docker://pgc-images.sbgenomics.com/d3b-bixu/open-pedcan:analysisjob | |||
| uses: docker://pgc-images.sbgenomics.com/d3b-bixu/open-pedcan:latest | |||
There was a problem hiding this comment.
Using the latest tag for analysis means that changes to the Dockerfile and changes to the packages/data HAVE to be separate PRs.
jharenza
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to CI:
This should allow for an economical use of large Github runners and cut the time to run the analysis job from over 2 and a half hours to about 30 minutes.