Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default geoCircle precision to 2 degrees #281

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

Fil
Copy link
Member

@Fil Fil commented Apr 28, 2023

Results in 180 control points instead of 60 (⨉3). The error is quadratic with the precision, with the worst case (for a parallel) being at latitude 45°. Under this new setting, the maximum error is now ~484m, vs. 4.365km with precision 6°.

https://observablehq.com/@d3/geocircle-error

Results in 180 control points instead of 60 (⨉3). The error is quadratic with the precision, with the worst case (for a parallel) being at latitude 45°. Under this new setting, the maximum error is now ~484m, vs. 4.365km with precision 6°.
https://observablehq.com/@d3/geocircle-error
@Fil Fil requested a review from mbostock April 28, 2023 00:39
@Fil Fil mentioned this pull request Apr 28, 2023
2 tasks
Fil added a commit that referenced this pull request Apr 28, 2023
following #281

(note that for clipCircle the precision is not modifiable by the user)

Manually rechecked each of the tests that are (slightly) modified as a consequence
Fil added a commit to d3/d3 that referenced this pull request Nov 20, 2023
@Fil
Copy link
Member Author

Fil commented Nov 20, 2023

linked documentation PR d3/d3#3803

mbostock added a commit to d3/d3 that referenced this pull request Mar 12, 2024
for when we merge d3/d3-geo#281

Co-authored-by: Mike Bostock <[email protected]>
@mbostock mbostock merged commit dcca6b2 into main Mar 12, 2024
1 check passed
@mbostock mbostock deleted the fil/default-circle-precision branch March 12, 2024 21:57
mbostock added a commit that referenced this pull request Mar 12, 2024
* default geoCircle precision to 2 degrees

Results in 180 control points instead of 60 (⨉3). The error is quadratic with the precision, with the worst case (for a parallel) being at latitude 45°. Under this new setting, the maximum error is now ~484m, vs. 4.365km with precision 6°.
https://observablehq.com/@d3/geocircle-error

* document

* refine clipCircle precision, from 6 degrees to 2 degrees
following #281

(note that for clipCircle the precision is not modifiable by the user)

Manually rechecked each of the tests that are (slightly) modified as a consequence

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants