Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipCircle's precision is too low #270

Closed
2 tasks done
Fil opened this issue Dec 16, 2022 · 0 comments · Fixed by #282
Closed
2 tasks done

clipCircle's precision is too low #270

Fil opened this issue Dec 16, 2022 · 0 comments · Fixed by #282
Assignees
@Fil
Labels
enhancement question

Comments

@Fil
Copy link
Member

Fil commented Dec 16, 2022 •
edited
Loading

The clipCircle's precision is 6 degrees (like geoCircle's precision), and the resulting segments are visibly linear on any azimuthal projection's sphere. I would like to make it either configurable (with a default of 6), or to change the value to 2 degrees.
I would also argue that geoCircle's default precision could be set to 2 degrees instead of 6. The trade-offs for speed vs quality might be a bit different 10 years later, with faster computers everywhere.
@Fil Fil self-assigned this Dec 16, 2022
Fil added a commit to observablehq/plot that referenced this issue Apr 27, 2023
@Fil
remove precision(2), which introduces unnecessary complexity
cec3394 
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)
mbostock pushed a commit to observablehq/plot that referenced this issue Apr 27, 2023
@Fil @mbostock
remove precision(2), which introduces unnecessary complexity
874a845 
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)
mbostock pushed a commit to observablehq/plot that referenced this issue Apr 27, 2023
@Fil @mbostock
remove precision(2), which introduces unnecessary complexity
dedafbd 
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)
mbostock added a commit to observablehq/plot that referenced this issue Apr 27, 2023
@Fil @mbostock
suggestions for the docs (#1500)
93d2b6b 
* remove precision(2), which introduces unnecessary complexity
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)

* projection-aware

* crs

* show local time

* sqrt is shorthand for pow

* link threshold to the domain option

* auto powers chart cell

* micro-document autoSpec

* avoid repetition

* simpler reading?

* infinite values are ignored

* remove links to (valuable but not crucial) prior art

* avoid repetition

* add a non-unique selector example (a sampler)

* remove unused energy table

* explicit "interface" instead of API.
An alternative might be to link to https://en.wikipedia.org/wiki/API, or use an abbr

* ask yourself

* named UTC intervals

* Update projections.md

* Update scales.md

* Update scales.md

* Update scales.md

* Update area.md

* Update auto.md

* Update bar.md

* fix links to sort mark option; document basic transforms

* move interval scale option to scales

* time, not necessarily UTC

* necessarily UTC

* infinity may not gap

* edit

* interval scale option tip

* remove blank line

* no ask yourself

---------

Co-authored-by: Mike Bostock <[email protected]>
@Fil Fil mentioned this issue Apr 28, 2023
Merged
frontend-provider pushed a commit to frontend-provider/plot that referenced this issue Sep 20, 2023
@Fil @mbostock
suggestions for the docs (#1500)
125653e 
* remove precision(2), which introduces unnecessary complexity
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)

* projection-aware

* crs

* show local time

* sqrt is shorthand for pow

* link threshold to the domain option

* auto powers chart cell

* micro-document autoSpec

* avoid repetition

* simpler reading?

* infinite values are ignored

* remove links to (valuable but not crucial) prior art

* avoid repetition

* add a non-unique selector example (a sampler)

* remove unused energy table

* explicit "interface" instead of API.
An alternative might be to link to https://en.wikipedia.org/wiki/API, or use an abbr

* ask yourself

* named UTC intervals

* Update projections.md

* Update scales.md

* Update scales.md

* Update scales.md

* Update area.md

* Update auto.md

* Update bar.md

* fix links to sort mark option; document basic transforms

* move interval scale option to scales

* time, not necessarily UTC

* necessarily UTC

* infinity may not gap

* edit

* interval scale option tip

* remove blank line

* no ask yourself

---------

Co-authored-by: Mike Bostock <[email protected]>
backend-devloper pushed a commit to backend-devloper/plot that referenced this issue Nov 24, 2023
@Fil @mbostock
suggestions for the docs (#1500)
6d74121 
* remove precision(2), which introduces unnecessary complexity
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)

* projection-aware

* crs

* show local time

* sqrt is shorthand for pow

* link threshold to the domain option

* auto powers chart cell

* micro-document autoSpec

* avoid repetition

* simpler reading?

* infinite values are ignored

* remove links to (valuable but not crucial) prior art

* avoid repetition

* add a non-unique selector example (a sampler)

* remove unused energy table

* explicit "interface" instead of API.
An alternative might be to link to https://en.wikipedia.org/wiki/API, or use an abbr

* ask yourself

* named UTC intervals

* Update projections.md

* Update scales.md

* Update scales.md

* Update scales.md

* Update area.md

* Update auto.md

* Update bar.md

* fix links to sort mark option; document basic transforms

* move interval scale option to scales

* time, not necessarily UTC

* necessarily UTC

* infinity may not gap

* edit

* interval scale option tip

* remove blank line

* no ask yourself

---------

Co-authored-by: Mike Bostock <[email protected]>
chaichontat pushed a commit to chaichontat/plot that referenced this issue Jan 14, 2024
@Fil @mbostock @chaichontat
suggestions for the docs (observablehq#1500)
821bae3 
* remove precision(2), which introduces unnecessary complexity
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)

* projection-aware

* crs

* show local time

* sqrt is shorthand for pow

* link threshold to the domain option

* auto powers chart cell

* micro-document autoSpec

* avoid repetition

* simpler reading?

* infinite values are ignored

* remove links to (valuable but not crucial) prior art

* avoid repetition

* add a non-unique selector example (a sampler)

* remove unused energy table

* explicit "interface" instead of API.
An alternative might be to link to https://en.wikipedia.org/wiki/API, or use an abbr

* ask yourself

* named UTC intervals

* Update projections.md

* Update scales.md

* Update scales.md

* Update scales.md

* Update area.md

* Update auto.md

* Update bar.md

* fix links to sort mark option; document basic transforms

* move interval scale option to scales

* time, not necessarily UTC

* necessarily UTC

* infinity may not gap

* edit

* interval scale option tip

* remove blank line

* no ask yourself

---------

Co-authored-by: Mike Bostock <[email protected]>
tigrevol8888 added a commit to tigrevol8888/plot that referenced this issue Jul 5, 2024
@tigrevol8888 @mbostock
suggestions for the docs (#1500)
677ce66 
* remove precision(2), which introduces unnecessary complexity
(for a nicer circle, I'd recommend we change the default precision of d3.geoCircle, cf. d3/d3-geo#270)

* projection-aware

* crs

* show local time

* sqrt is shorthand for pow

* link threshold to the domain option

* auto powers chart cell

* micro-document autoSpec

* avoid repetition

* simpler reading?

* infinite values are ignored

* remove links to (valuable but not crucial) prior art

* avoid repetition

* add a non-unique selector example (a sampler)

* remove unused energy table

* explicit "interface" instead of API.
An alternative might be to link to https://en.wikipedia.org/wiki/API, or use an abbr

* ask yourself

* named UTC intervals

* Update projections.md

* Update scales.md

* Update scales.md

* Update scales.md

* Update area.md

* Update auto.md

* Update bar.md

* fix links to sort mark option; document basic transforms

* move interval scale option to scales

* time, not necessarily UTC

* necessarily UTC

* infinity may not gap

* edit

* interval scale option tip

* remove blank line

* no ask yourself

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fil Fil

Labels
enhancement question
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set clipCircle precision to 2 degrees d3/d3-geo
1 participant
@Fil