Bump stacks for Stabilization/VTXConfig on F4 #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2016 17:19
* We're having some field reports of brain reboots, although the cause is undefined due to a problem with the boot reason detection on F4. * Stabilization stack size was down to 40 free so bump it by 60.
* This was running really close to the line (24 bytes avail.)
mlyle
added
bug
bug/safety
flight
status/ready-for-merge
BLOCKER 🛑
and removed
status/work-in-progress
labels
|
My son flew 5 packs and I flew 4 on two different quads using build 459 that includes this PR with no issues. Funny thing is that I broke mine after the 4th flight, so I took out the backup quad that was still on 455 without this PR. Halfway through the first pack it rebooted. So, I'm pretty confident that the issue is fixed. |
|
Well, we'll hang out a bit longer looking for unexplained crashes. One thign that would be pretty clear evidence is if we saw a quad with less than 68 bytes of stack in the stabilization module (since we increased stack by 60 bytes) after this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1123. I flew this for 4 batteries (20 minutes or so of airtime) and no boot:undefined/reset so far.