Add --format option and base32 support for otp set #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinkrahl
force-pushed
the
wip/format-option
branch
from
379f017 to
d5a93a4
Compare
This patch introduces the -f, --format options for the otp set subcommand to specify the format of the OTP secret. Previously, the default format as hex and ASCII format could be selected using the --ascii option. The new --format option takes the argument hex or ascii, defaulting to hex, and replaces the --ascii option. This patch does not remove the --ascii option but marks it as deprecated. It may not be set together with --format, and a warning is printed if it is set. It should be deleted with the next minor release. This patch prepares the addition of a new format, base32.
This patch refactors the prepare_secret function by renaming it to prepare_ascii_secret and by moving the formatting of a bytes slice as a hex string into the format_bytes function. This prepares for adding a the base32 format in a future patch.
To parse OTP secrets in base32 representation, we need a new dependency: the base32 crate.
robinkrahl
force-pushed
the
wip/format-option
branch
from
d5a93a4 to
655f11f
Compare
Many applications display OTP secrets in the base32 format (according to RFC 4648). This patch adds this base32 as possible value for the --format option for the otp set subcommand.
|
Thanks for implementing this functionality so quickly, Robin! I plan to look at this pull request first thing tomorrow. |
|
Looks great as usual, @robinkrahl . Merged into |
|
Thanks for merging and adding the dependencies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.