Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support base32 OTP secrets #46

Closed
robinkrahl opened this issue Jan 5, 2019 · 5 comments
Closed

Support base32 OTP secrets #46

robinkrahl opened this issue Jan 5, 2019 · 5 comments
Assignees

Comments

@robinkrahl
Copy link
Collaborator

Apparently, the de-facto standard set by Google Authenticator is sharing OTP secrets as base32 strings. We should support this input type in otp set. I suggest to replace the --ascii option with a --format [ascii|hex|base32] option.

@d-e-s-o
Copy link
Owner

d-e-s-o commented Jan 5, 2019

Interesting. The suggestion sounds good! Do you plan to take care of that, @robinkrahl ?

@robinkrahl
Copy link
Collaborator Author

I added it to the list in the wiki. Probably, but I’ve got some other things to investigate first.

@robinkrahl
Copy link
Collaborator Author

I’ll need an additional dependency, base32, to implement this. Do you have an automated solution to add a crate and its dependencies to the repository or do you manually add them? Also this crate depends on rand ^0.5.5 while we currently have v0.6.1. Should we patch one of the crates to only have one rand version or should we include both?

@d-e-s-o
Copy link
Owner

d-e-s-o commented Jan 5, 2019

Do you have an automated solution to add a crate and its dependencies to the repository or do you manually add them?

I manually add them. Don't worry about it, just update Cargo.toml and I'll take care of it before merging.

Also this crate depends on rand ^0.5.5 while we currently have v0.6.1. Should we patch one of the crates to only have one rand version or should we include both?

I checked and it's a dev-dependency. I am fine not vendoring those (and since it won't be included in the binary having two versions consumed is fine), so we should be good.

@robinkrahl
Copy link
Collaborator Author

Done with #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants