Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bash #16

Closed
wants to merge 1 commit into from
Closed

add bash #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ RUN set -eux \
musl-dev \
openssl-dev \
python3 \
python3-dev
python3-dev \
bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomach thanks for the contribution! Any specifics on why bash is required for the linting?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my use case I need to run some more scripts on Jenkins. So I start this image as a slave and run the linting as one of 3 steps. The other steps are bash scripts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my use case I need to run some more scripts on Jenkins. So I start this image as a slave and run the linting as one of 3 steps. The other steps are bash scripts

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomach this is the build image. Anything added here will not be present in the final image. bash should be added on line 32


ARG VERSION=latest
RUN set -eux \
Expand Down