add bash #16
Closed
add bash #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cytopia
reviewed
Jan 17, 2020
| @@ -8,7 +8,8 @@ RUN set -eux \ | |||
| musl-dev \ | |||
| openssl-dev \ | |||
| python3 \ | |||
| python3-dev | |||
| python3-dev \ | |||
| bash | |||
There was a problem hiding this comment.
@jomach thanks for the contribution! Any specifics on why bash is required for the linting?
There was a problem hiding this comment.
For my use case I need to run some more scripts on Jenkins. So I start this image as a slave and run the linting as one of 3 steps. The other steps are bash scripts
There was a problem hiding this comment.
For my use case I need to run some more scripts on Jenkins. So I start this image as a slave and run the linting as one of 3 steps. The other steps are bash scripts
There was a problem hiding this comment.
@jomach this is the build image. Anything added here will not be present in the final image. bash should be added on line 32
|
Closing in favour of: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15