Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cypress v10 tests to 12.3.0 #725

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Update Cypress v10 tests to 12.3.0 #725

merged 1 commit into from
Jan 13, 2023

Conversation

MikeMcC399
Copy link
Collaborator

This PR resolves issue #684 "v10 examples do not use latest version 12.2.0".

Each of the test directories in examples/v10 is upgraded to use Cypress 12.3.0.

  1. The npm-based v10 examples are updated using:
    ./scripts/npm-install-v10-examples.sh. This updates package.json to include "cypress": "^12.3.0"

  2. examples/v10/start-and-yarn-workspaces is updated using:
    yarn upgrade-interactive --latest

  3. examples/v10/install-command is updated using:
    yarn add cypress -D

  4. examples/v10/basic-pnpm is updated using:
    pnpm up --latest

A next stage may be to rename the directory examples/v10, or eliminate it, to make it more inline with the Cypress 12.x version being used.

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

I suggest to merge this PR independently of any decision to rename the v10 directory or move it.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 13, 2023 09:53
@MikeMcC399 MikeMcC399 mentioned this pull request Jan 13, 2023
Closed
@MikeMcC399 MikeMcC399 marked this pull request as draft January 13, 2023 15:04
@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Jan 13, 2023 •
edited
Loading

checking sha1 to sha512 conversions in various package-lock.json files
Edit: There was a minor discrepancy in https://github.com/cypress-io/github-action/blob/master/examples/v10/basic/package-lock.json so I reverted and re-did the upgrade to 12.3.0. It seems fine now.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 13, 2023 15:47
jaffrepaul
jaffrepaul approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeMcC399! I think we should just remove the v10 level in a separate PR to imply cypress(latest) with the additional v9 set.

@jaffrepaul jaffrepaul merged commit f4207e1 into cypress-io:master Jan 13, 2023
@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

Thanks!

You're welcome! And thank you for merging!

I think we should just remove the v10 level in a separate PR to imply cypress(latest) with the additional v9 set.

That makes sense to promote the v12.x examples up a level and remove the v10 label and level. I'll make that the next PR for next week as it will have knock-on effects for any other work, so it will be good to have a new base to work on.

@jaffrepaul
Copy link
Contributor

Love it. Have a great weekend!

@MikeMcC399
Copy link
Collaborator Author

Thanks and same to you!

This was referenced Jan 16, 2023
Merged
Closed
@MikeMcC399 MikeMcC399 mentioned this pull request Jan 24, 2023
Closed
@github-actions
Copy link

🎉 This PR is included in version 5.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaffrepaul jaffrepaul jaffrepaul approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcC399 @jaffrepaul