-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v10 examples do not use latest version 12.x #684
Comments
|
Any feedback on this suggestion? It makes sense to me to update. |
Agreed. We're working to get all of our ancillary tools and repos to use the latest version of Cypress. Certainly applies here. We'll need to land on some appropriate naming conventions, i.e the |
The naming of examples/v10 would be misleading after updating the examples to Cypress 12.x. So I follow your thinking about settling on a different naming convention. One possibility would be:
If there is a prospect in the future of another breaking change in Cypress which could create the need for another complete set of compatible examples, then it would be better to keep the v10 level and rename
Removing the v10 level would be my first choice and renaming v10 to v1x would be my second choice. |
If there is a change in the v10 directory I would suggest to split the changes into two separate PRs:
That would make it easier for testing and review. |
|
Next step:
|
Current situation
Example workflows in examples/v10 are configured to use Cypress 10.0.0, released on June 1, 2022. Since then, Cypress 11 and Cypress 12 have been released. The version is stored in
package.json
files,package-lock.json
,yarn.lock
andpnpm-lock.yaml
files.Suggested change
Update all v10 example workflows in examples/v10 to use the latest Cypress version according to the Cypress changelog.
Benefits
Updating the v10 examples to use the latest Cypress version provides increased confidence that GHA is up-to-date and compatible with the latest Cypress major version (12).
The text was updated successfully, but these errors were encountered: