Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10 examples do not use latest version 12.x #684

Closed
MikeMcC399 opened this issue Dec 27, 2022 · 7 comments
Closed

v10 examples do not use latest version 12.x #684

MikeMcC399 opened this issue Dec 27, 2022 · 7 comments

Comments

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Dec 27, 2022

Current situation

Example workflows in examples/v10 are configured to use Cypress 10.0.0, released on June 1, 2022. Since then, Cypress 11 and Cypress 12 have been released. The version is stored in package.json files, package-lock.json, yarn.lock and pnpm-lock.yaml files.

Suggested change

Update all v10 example workflows in examples/v10 to use the latest Cypress version according to the Cypress changelog.

Benefits

Updating the v10 examples to use the latest Cypress version provides increased confidence that GHA is up-to-date and compatible with the latest Cypress major version (12).

@MikeMcC399
Copy link
Collaborator Author

  • I already successfully tested updating the v10 examples to use Cypress 12, however I will hold back on submitting a PR until PR Update serve packages flagged by snyk #673 is completed to avoid getting into package-lock.json and yarn.lock conflicts. Also it would be good to hear if updating is actually wanted or not.

@MikeMcC399 MikeMcC399 changed the title v10 examples do not use latest version 12.2.0 v10 examples do not use latest version 12.x Jan 4, 2023
@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

Any feedback on this suggestion? It makes sense to me to update.

@jaffrepaul
Copy link
Contributor

Agreed. We're working to get all of our ancillary tools and repos to use the latest version of Cypress. Certainly applies here. We'll need to land on some appropriate naming conventions, i.e the /v10 folder, etc.

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

We'll need to land on some appropriate naming conventions, i.e the /v10 folder, etc.

The naming of examples/v10 would be misleading after updating the examples to Cypress 12.x. So I follow your thinking about settling on a different naming convention.

One possibility would be:

  • examples/v9 - leave unchanged
  • examples - remove the v10 level and move it up one level for 12.x and any later versions

If there is a prospect in the future of another breaking change in Cypress which could create the need for another complete set of compatible examples, then it would be better to keep the v10 level and rename v10 in examples/v10 to, for example, one of the following:

  • v1x (which would cover Cypress versions 10-19)
  • v1n
  • current
  • latest

Removing the v10 level would be my first choice and renaming v10 to v1x would be my second choice.

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

If there is a change in the v10 directory I would suggest to split the changes into two separate PRs:

  1. No change to v10 directory, update Cypress to latest 12.x
  2. Change the directory name or location for the 12.x tests. This also affects documentation.

That would make it easier for testing and review.

@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Jan 13, 2023

@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Jan 13, 2023

Next step:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants