Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(desktop-gui): remember last browser used w/ non-default channel #8284

Merged
merged 2 commits into from
Aug 15, 2020
Merged

fix(desktop-gui): remember last browser used w/ non-default channel #8284

merged 2 commits into from
Aug 15, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Aug 14, 2020 •
edited by bahmutov
Loading

User facing changelog

  • Fixed a bug where the "last used browser" would be incorrectly remembered in cypress open if a non-default-channel browser was selected.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 14, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 14, 2020 •
edited
Loading


Test summary

8118 • 0 • 108 • 3

Run details
Project cypress
Status Passed
Commit ee60b01
Started Aug 14, 2020 7:36 PM
Ended Aug 14, 2020 7:42 PM
Duration 05:45 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review August 14, 2020 17:23
bahmutov
bahmutov reviewed Aug 14, 2020
View reviewed changes
packages/desktop-gui/cypress/integration/project_nav_spec.js Outdated
@@ -318,8 +318,15 @@ describe('Project Nav', function () {
})

describe('local storage saved browser', function () {
// deliberately not the default 'chrome' browser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we clearly have 3 tests here:

  • nothing is in localStorage under choseBrowser
  • old way chromium
  • new way with stringified object

bahmutov
bahmutov previously approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, I just want clear tests for different situations to ensure the code is covered

@flotwig flotwig requested a review from bahmutov August 14, 2020 19:32
bahmutov
bahmutov approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bahmutov bahmutov merged commit 204cb01 into develop Aug 15, 2020
@cypress-bot cypress-bot bot mentioned this pull request Aug 15, 2020
Closed
@flotwig flotwig deleted the issue-8281 branch January 24, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov approved these changes

@chrisbreiding chrisbreiding Awaiting requested review from chrisbreiding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last-used browser is incorrectly remembered in desktop-gui
2 participants
@flotwig @bahmutov