fix: it.skip no longer causes hooks to be assigned to the wrong test

[panzarino]

• Closes it.skip before describe causing problems in both command line run and debugger #8086
• Closes "Cannot set property 'err' of undefined" error occurs in place of other errors during automatic test-reruns on file save. #7874

User facing changelog

• Fixes an issue where placing an it.skip on the last test before a nested suite with a before hook would cause the remainder of tests not to show up
• Prevents error "Cannot set property 'err' of undefined" error occurs in place of other errors during automatic test-reruns on file save.

How has the user experience changed?

Given a test that looks like the following:

describe("UPPER", () => {
  it.skip("TEST1", () => {})

  describe("LOWER", () => {
    before(() => {
      cy.wait(1000);
    })

    it("TEST2", () => {})
  })
})

cypress open

Before:

After:

cypress run

Before:

After:

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[sainthkh]

Closes #8096 might accidentally close a valid PR.

[cypress]

---

Test summary

7929 • 0 • 130 • 2

---

Run details

Project	cypress
Status	Passed
Commit	a5ac913
Started	Aug 3, 2020 5:46 PM
Ended	Aug 3, 2020 5:53 PM
Duration	06:43 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[panzarino]

@sainthkh Thanks for pointing that out, meant to reference 8086, sorry for the confusion.

[jennifer-shehane]

Manually verified that this fixes the original issue.

[panzarino]

Looks like when .skip is used (at least in this example), _runner.on('test', ... is not being fired, so setTest() is never called. This makes me wonder whether we should fix this so that setTest() sets the correct test or just remove all usages of setTest() and getTest(). @bkucera said he would look into it.

[kuceb]

So the issue was setting hook.ctx.currentTest back to getTest() when we meant to delete hook.ctx.currentTest and find it from runnables list again, not sure how that wasn't caught. So i undid one of the deletions of getTest() and only left necessary changes.