4.12.1 Regression: after() block causes errors in before() to be hidden

[kpittman-securus]

Current behavior

If I have a before() that threw an error, and anything (or even nothing) inside an after() block, the test runner gets hung up and will not display the error from the before().

This behavior only occurs on tests with multiple it blocks.

Desired behavior

Should behave the same as when I remove the after()

• display the error and exit cleanly.

Test code to reproduce

describe("A spec with an after() block has an error in a before() block", () => {
  before(() => {
    cy.request("https://httpstat.us/404");
  });
  after(() => {
    cy.log("after"); // if you remove these 3 lines - the entire after() block, not just the cy.log - the stack trace is shown correctly
  });
  it("has a test", () => {
    expect(true).to.be.true;
  });
  it("has another test", () => {
    expect(true).to.be.true;
  });
});

Versions

At least 4.12.1 through 5.6.0

[jennifer-shehane]

This is a regression introduced in 4.12.1. This must have been introduced in #8113, since there were very few commits in this release and that one involves test hooks.

describe('hangs when error in a before() block', () => {
  before(() => {
    expect(true).to.be.false
  })
  after(() => {})
  it('has a test')
  it('has another test')
})

4.12.0

4.12.1

[cypress-bot]

The code for this is done in cypress-io/cypress#9527, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 6.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.1.0, please open a new issue.